Skip to content

Commit 8bf24e8

Browse files
mpeShuah Khan
authored andcommitted
selftests/filesystems: Don't run dnotify_test by default
In commit ce290a1 ("selftests: add devpts selftests"), the filesystems directory was added to the top-level selftests Makefile. That had the effect of causing the existing dnotify_test in the filesystems directory to now be run as part of the default selftests test-run. Unfortunately dnotify_test is actually an infinite loop. Fix it by moving dnotify_test to TEST_GEN_PROGS_EXTENDED, which says that it's a generated file (ie. built) but should not be run as part of the default test suite run (it's an "extended" test). While we're here cleanup a few other things, devpts_pts should be in TEST_GEN_PROGS to indicate that it's built, and with the above two changes we no longer need a custom all or clean rule. Fixes: ce290a1 ("selftests: add devpts selftests") Signed-off-by: Michael Ellerman <[email protected]> Acked-by: Christian brauner <[email protected]> Signed-off-by: Shuah Khan <[email protected]>
1 parent 60cc43f commit 8bf24e8

File tree

1 file changed

+3
-5
lines changed
  • tools/testing/selftests/filesystems

1 file changed

+3
-5
lines changed
Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
# SPDX-License-Identifier: GPL-2.0
2-
TEST_PROGS := dnotify_test devpts_pts
3-
all: $(TEST_PROGS)
42

5-
include ../lib.mk
3+
TEST_GEN_PROGS := devpts_pts
4+
TEST_GEN_PROGS_EXTENDED := dnotify_test
65

7-
clean:
8-
rm -fr $(TEST_PROGS)
6+
include ../lib.mk

0 commit comments

Comments
 (0)