Skip to content

Commit 8c51b31

Browse files
anakryikoborkmann
authored andcommitted
selftests/bpf: switch test to new attach_perf_event API
Use new bpf_program__attach_perf_event() in test previously relying on direct ioctl manipulations. Signed-off-by: Andrii Nakryiko <[email protected]> Reviewed-by: Stanislav Fomichev <[email protected]> Acked-by: Song Liu <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]>
1 parent 84bf5e1 commit 8c51b31

File tree

1 file changed

+15
-16
lines changed

1 file changed

+15
-16
lines changed

tools/testing/selftests/bpf/prog_tests/stacktrace_build_id_nmi.c

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ static __u64 read_perf_max_sample_freq(void)
1717
void test_stacktrace_build_id_nmi(void)
1818
{
1919
int control_map_fd, stackid_hmap_fd, stackmap_fd, stack_amap_fd;
20+
const char *prog_name = "tracepoint/random/urandom_read";
2021
const char *file = "./test_stacktrace_build_id.o";
2122
int err, pmu_fd, prog_fd;
2223
struct perf_event_attr attr = {
@@ -25,7 +26,9 @@ void test_stacktrace_build_id_nmi(void)
2526
.config = PERF_COUNT_HW_CPU_CYCLES,
2627
};
2728
__u32 key, previous_key, val, duration = 0;
29+
struct bpf_program *prog;
2830
struct bpf_object *obj;
31+
struct bpf_link *link;
2932
char buf[256];
3033
int i, j;
3134
struct bpf_stack_build_id id_offs[PERF_MAX_STACK_DEPTH];
@@ -39,6 +42,10 @@ void test_stacktrace_build_id_nmi(void)
3942
if (CHECK(err, "prog_load", "err %d errno %d\n", err, errno))
4043
return;
4144

45+
prog = bpf_object__find_program_by_title(obj, prog_name);
46+
if (CHECK(!prog, "find_prog", "prog '%s' not found\n", prog_name))
47+
goto close_prog;
48+
4249
pmu_fd = syscall(__NR_perf_event_open, &attr, -1 /* pid */,
4350
0 /* cpu 0 */, -1 /* group id */,
4451
0 /* flags */);
@@ -47,15 +54,12 @@ void test_stacktrace_build_id_nmi(void)
4754
pmu_fd, errno))
4855
goto close_prog;
4956

50-
err = ioctl(pmu_fd, PERF_EVENT_IOC_ENABLE, 0);
51-
if (CHECK(err, "perf_event_ioc_enable", "err %d errno %d\n",
52-
err, errno))
53-
goto close_pmu;
54-
55-
err = ioctl(pmu_fd, PERF_EVENT_IOC_SET_BPF, prog_fd);
56-
if (CHECK(err, "perf_event_ioc_set_bpf", "err %d errno %d\n",
57-
err, errno))
58-
goto disable_pmu;
57+
link = bpf_program__attach_perf_event(prog, pmu_fd);
58+
if (CHECK(IS_ERR(link), "attach_perf_event",
59+
"err %ld\n", PTR_ERR(link))) {
60+
close(pmu_fd);
61+
goto close_prog;
62+
}
5963

6064
/* find map fds */
6165
control_map_fd = bpf_find_map(__func__, obj, "control_map");
@@ -134,8 +138,7 @@ void test_stacktrace_build_id_nmi(void)
134138
* try it one more time.
135139
*/
136140
if (build_id_matches < 1 && retry--) {
137-
ioctl(pmu_fd, PERF_EVENT_IOC_DISABLE);
138-
close(pmu_fd);
141+
bpf_link__destroy(link);
139142
bpf_object__close(obj);
140143
printf("%s:WARN:Didn't find expected build ID from the map, retrying\n",
141144
__func__);
@@ -154,11 +157,7 @@ void test_stacktrace_build_id_nmi(void)
154157
*/
155158

156159
disable_pmu:
157-
ioctl(pmu_fd, PERF_EVENT_IOC_DISABLE);
158-
159-
close_pmu:
160-
close(pmu_fd);
161-
160+
bpf_link__destroy(link);
162161
close_prog:
163162
bpf_object__close(obj);
164163
}

0 commit comments

Comments
 (0)