Skip to content

Commit 8cd1b5b

Browse files
committed
ALSA: hda - Silence PM ops build warning
The system sleep PM ops azx_suspend() and azx_resume() were previously called by vga_switcheroo, but commit 07f4f97 ("vga_switcheroo: Use device link for HDA controller") removed their invocation. Unfortunately the commit neglected to update the #ifdef surrounding the two functions, so if CONFIG_PM_SLEEP is *not* enabled but all three of CONFIG_PM, CONFIG_VGA_SWITCHEROO and CONFIG_SND_HDA_CODEC_HDMI *are* enabled, the compiler now emits the following warning: sound/pci/hda/hda_intel.c:1024:12: warning: 'azx_resume' defined but not used [-Wunused-function] static int azx_resume(struct device *dev) ^~~~~~~~~~ sound/pci/hda/hda_intel.c:989:12: warning: 'azx_suspend' defined but not used [-Wunused-function] static int azx_suspend(struct device *dev) ^~~~~~~~~~~ Silence by updating the #ifdef. Because the #ifdef block now uses the same condition as the one immediately succeeding it, the two blocks can be collapsed together, shaving off another two lines. Fixes: 07f4f97 ("vga_switcheroo: Use device link for HDA controller") Reviewed-by: Takashi Iwai <[email protected]> Reported-by: Arnd Bergmann <[email protected]> Signed-off-by: Lukas Wunner <[email protected]> Link: https://patchwork.kernel.org/patch/10313441/ Link: https://patchwork.freedesktop.org/patch/msgid/b8e70e34a9acbd4f0a1a6c7673cea96888ae9503.1522323444.git.lukas@wunner.de
1 parent a01c477 commit 8cd1b5b

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

sound/pci/hda/hda_intel.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -982,7 +982,7 @@ static int param_set_xint(const char *val, const struct kernel_param *kp)
982982
#define azx_del_card_list(chip) /* NOP */
983983
#endif /* CONFIG_PM */
984984

985-
#if defined(CONFIG_PM_SLEEP) || defined(SUPPORT_VGA_SWITCHEROO)
985+
#ifdef CONFIG_PM_SLEEP
986986
/*
987987
* power management
988988
*/
@@ -1063,9 +1063,7 @@ static int azx_resume(struct device *dev)
10631063
trace_azx_resume(chip);
10641064
return 0;
10651065
}
1066-
#endif /* CONFIG_PM_SLEEP || SUPPORT_VGA_SWITCHEROO */
10671066

1068-
#ifdef CONFIG_PM_SLEEP
10691067
/* put codec down to D3 at hibernation for Intel SKL+;
10701068
* otherwise BIOS may still access the codec and screw up the driver
10711069
*/

0 commit comments

Comments
 (0)