Skip to content

Commit 8d047bf

Browse files
ayalevin123Saeed Mahameed
authored andcommitted
net/mlx5: ethtool, Fix type analysis of advertised link-mode
Ethtool option set_link_ksettings allows setting of legacy link-modes or extended link-modes. Refine the decision of which type of link-modes is set. Fixes: 6a89737 ("net/mlx5: ethtool, Add ethtool support for 50Gbps per lane link modes") Signed-off-by: Aya Levin <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent 80a2a90 commit 8d047bf

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -997,8 +997,9 @@ int mlx5e_ethtool_set_link_ksettings(struct mlx5e_priv *priv,
997997

998998
#define MLX5E_PTYS_EXT ((1ULL << ETHTOOL_LINK_MODE_50000baseKR_Full_BIT) - 1)
999999

1000-
ext_requested = (link_ksettings->link_modes.advertising[0] >
1001-
MLX5E_PTYS_EXT);
1000+
ext_requested = !!(link_ksettings->link_modes.advertising[0] >
1001+
MLX5E_PTYS_EXT ||
1002+
link_ksettings->link_modes.advertising[1]);
10021003
ext_supported = MLX5_CAP_PCAM_FEATURE(mdev, ptys_extended_ethernet);
10031004

10041005
/*when ptys_extended_ethernet is set legacy link modes are deprecated */

0 commit comments

Comments
 (0)