Skip to content

Commit 8d93c7a

Browse files
committed
Merge tag 'pci-v4.14-fixes-1' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci
Pull PCI fix from Bjorn Helgaas: "Revert an attempt to fix a race while enabling upstream bridges because it broke iwlwifi firmware loading" * tag 'pci-v4.14-fixes-1' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci: Revert "PCI: Avoid race while enabling upstream bridges"
2 parents 02cfe97 + 0f50a49 commit 8d93c7a

File tree

1 file changed

+2
-11
lines changed

1 file changed

+2
-11
lines changed

drivers/pci/pci.c

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ static void pci_pme_list_scan(struct work_struct *work);
5252
static LIST_HEAD(pci_pme_list);
5353
static DEFINE_MUTEX(pci_pme_list_mutex);
5454
static DECLARE_DELAYED_WORK(pci_pme_work, pci_pme_list_scan);
55-
static DEFINE_MUTEX(pci_bridge_mutex);
5655

5756
struct pci_pme_device {
5857
struct list_head list;
@@ -1351,25 +1350,17 @@ static void pci_enable_bridge(struct pci_dev *dev)
13511350
if (bridge)
13521351
pci_enable_bridge(bridge);
13531352

1354-
/*
1355-
* Hold pci_bridge_mutex to prevent a race when enabling two
1356-
* devices below the bridge simultaneously. The race may cause a
1357-
* PCI_COMMAND_MEMORY update to be lost (see changelog).
1358-
*/
1359-
mutex_lock(&pci_bridge_mutex);
13601353
if (pci_is_enabled(dev)) {
13611354
if (!dev->is_busmaster)
13621355
pci_set_master(dev);
1363-
goto end;
1356+
return;
13641357
}
13651358

13661359
retval = pci_enable_device(dev);
13671360
if (retval)
13681361
dev_err(&dev->dev, "Error enabling bridge (%d), continuing\n",
13691362
retval);
13701363
pci_set_master(dev);
1371-
end:
1372-
mutex_unlock(&pci_bridge_mutex);
13731364
}
13741365

13751366
static int pci_enable_device_flags(struct pci_dev *dev, unsigned long flags)
@@ -1394,7 +1385,7 @@ static int pci_enable_device_flags(struct pci_dev *dev, unsigned long flags)
13941385
return 0; /* already enabled */
13951386

13961387
bridge = pci_upstream_bridge(dev);
1397-
if (bridge && !pci_is_enabled(bridge))
1388+
if (bridge)
13981389
pci_enable_bridge(bridge);
13991390

14001391
/* only skip sriov related */

0 commit comments

Comments
 (0)