Skip to content

Commit 8dcc3be

Browse files
committed
Merge tag 'trace-fixes-v3.16-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace
Pull trace fix from Steven Rostedt: "Tony Luck found that using the "uptime" trace clock that uses jiffies as a counter was converted to nanoseconds (silly), and after 1 hour 11 minutes and 34 seconds, this monotonic clock would wrap, causing havoc with the tracing system and making the clock useless. He converted that clock to use jiffies_64 and made it into a counter instead of nanosecond conversions, and displayed the clock with the straight jiffy count, which works much better than it did in the past" * tag 'trace-fixes-v3.16-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace: tracing: Fix wraparound problems in "uptime" trace clock
2 parents 67dd8f3 + 58d4e21 commit 8dcc3be

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

kernel/trace/trace.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -823,7 +823,7 @@ static struct {
823823
{ trace_clock_local, "local", 1 },
824824
{ trace_clock_global, "global", 1 },
825825
{ trace_clock_counter, "counter", 0 },
826-
{ trace_clock_jiffies, "uptime", 1 },
826+
{ trace_clock_jiffies, "uptime", 0 },
827827
{ trace_clock, "perf", 1 },
828828
ARCH_TRACE_CLOCKS
829829
};

kernel/trace/trace_clock.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,14 @@ u64 notrace trace_clock(void)
5959

6060
/*
6161
* trace_jiffy_clock(): Simply use jiffies as a clock counter.
62+
* Note that this use of jiffies_64 is not completely safe on
63+
* 32-bit systems. But the window is tiny, and the effect if
64+
* we are affected is that we will have an obviously bogus
65+
* timestamp on a trace event - i.e. not life threatening.
6266
*/
6367
u64 notrace trace_clock_jiffies(void)
6468
{
65-
u64 jiffy = jiffies - INITIAL_JIFFIES;
66-
67-
/* Return nsecs */
68-
return (u64)jiffies_to_usecs(jiffy) * 1000ULL;
69+
return jiffies_64_to_clock_t(jiffies_64 - INITIAL_JIFFIES);
6970
}
7071

7172
/*

0 commit comments

Comments
 (0)