Skip to content

Commit 8e45c6f

Browse files
Mike Christieaxboe
authored andcommitted
ide cd: do not set REQ_WRITE on requests.
The block layer will set the correct READ/WRITE operation flags/fields when creating a request, so there is not need for drivers to set the REQ_WRITE flag. Signed-off-by: Mike Christie <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Reviewed-by: Hannes Reinecke <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent 1b9a9ab commit 8e45c6f

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/ide/ide-cd_ioctl.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -459,9 +459,6 @@ int ide_cdrom_packet(struct cdrom_device_info *cdi,
459459
layer. the packet must be complete, as we do not
460460
touch it at all. */
461461

462-
if (cgc->data_direction == CGC_DATA_WRITE)
463-
flags |= REQ_WRITE;
464-
465462
if (cgc->sense)
466463
memset(cgc->sense, 0, sizeof(struct request_sense));
467464

0 commit comments

Comments
 (0)