@@ -56,7 +56,6 @@ MODULE_LICENSE("GPL v2");
56
56
* @format: current pix format
57
57
* @input: current video input (0 = SDTV, 1 = HDTV)
58
58
* @queue: vb2 video capture queue
59
- * @alloc_ctx: vb2 contiguous DMA context
60
59
* @qlock: spinlock controlling access to buf_list and sequence
61
60
* @buf_list: list of buffers queued for DMA
62
61
* @sequence: frame sequence counter
@@ -73,7 +72,6 @@ struct skeleton {
73
72
unsigned input ;
74
73
75
74
struct vb2_queue queue ;
76
- struct vb2_alloc_ctx * alloc_ctx ;
77
75
78
76
spinlock_t qlock ;
79
77
struct list_head buf_list ;
@@ -182,7 +180,6 @@ static int queue_setup(struct vb2_queue *vq,
182
180
183
181
if (vq -> num_buffers + * nbuffers < 3 )
184
182
* nbuffers = 3 - vq -> num_buffers ;
185
- alloc_ctxs [0 ] = skel -> alloc_ctx ;
186
183
187
184
if (* nplanes )
188
185
return sizes [0 ] < skel -> format .sizeimage ? - EINVAL : 0 ;
@@ -820,6 +817,7 @@ static int skeleton_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
820
817
q = & skel -> queue ;
821
818
q -> type = V4L2_BUF_TYPE_VIDEO_CAPTURE ;
822
819
q -> io_modes = VB2_MMAP | VB2_DMABUF | VB2_READ ;
820
+ q -> dev = & pdev -> dev ;
823
821
q -> drv_priv = skel ;
824
822
q -> buf_struct_size = sizeof (struct skel_buffer );
825
823
q -> ops = & skel_qops ;
@@ -850,12 +848,6 @@ static int skeleton_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
850
848
if (ret )
851
849
goto free_hdl ;
852
850
853
- skel -> alloc_ctx = vb2_dma_contig_init_ctx (& pdev -> dev );
854
- if (IS_ERR (skel -> alloc_ctx )) {
855
- dev_err (& pdev -> dev , "Can't allocate buffer context" );
856
- ret = PTR_ERR (skel -> alloc_ctx );
857
- goto free_hdl ;
858
- }
859
851
INIT_LIST_HEAD (& skel -> buf_list );
860
852
spin_lock_init (& skel -> qlock );
861
853
@@ -885,13 +877,11 @@ static int skeleton_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
885
877
886
878
ret = video_register_device (vdev , VFL_TYPE_GRABBER , -1 );
887
879
if (ret )
888
- goto free_ctx ;
880
+ goto free_hdl ;
889
881
890
882
dev_info (& pdev -> dev , "V4L2 PCI Skeleton Driver loaded\n" );
891
883
return 0 ;
892
884
893
- free_ctx :
894
- vb2_dma_contig_cleanup_ctx (skel -> alloc_ctx );
895
885
free_hdl :
896
886
v4l2_ctrl_handler_free (& skel -> ctrl_handler );
897
887
v4l2_device_unregister (& skel -> v4l2_dev );
@@ -907,7 +897,6 @@ static void skeleton_remove(struct pci_dev *pdev)
907
897
908
898
video_unregister_device (& skel -> vdev );
909
899
v4l2_ctrl_handler_free (& skel -> ctrl_handler );
910
- vb2_dma_contig_cleanup_ctx (skel -> alloc_ctx );
911
900
v4l2_device_unregister (& skel -> v4l2_dev );
912
901
pci_disable_device (skel -> pdev );
913
902
}
0 commit comments