Skip to content

Commit 904d88d

Browse files
bmorkdavem330
authored andcommitted
qmi_wwan: Fix out-of-bounds read
The syzbot reported Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0xca/0x13e lib/dump_stack.c:113 print_address_description+0x67/0x231 mm/kasan/report.c:188 __kasan_report.cold+0x1a/0x32 mm/kasan/report.c:317 kasan_report+0xe/0x20 mm/kasan/common.c:614 qmi_wwan_probe+0x342/0x360 drivers/net/usb/qmi_wwan.c:1417 usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361 really_probe+0x281/0x660 drivers/base/dd.c:509 driver_probe_device+0x104/0x210 drivers/base/dd.c:670 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:777 bus_for_each_drv+0x15c/0x1e0 drivers/base/bus.c:454 Caused by too many confusing indirections and casts. id->driver_info is a pointer stored in a long. We want the pointer here, not the address of it. Thanks-to: Hillf Danton <[email protected]> Reported-by: [email protected] Cc: Kristian Evensen <[email protected]> Fixes: e4bf634 ("qmi_wwan: Add quirk for Quectel dynamic config") Signed-off-by: Bjørn Mork <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 4f07b80 commit 904d88d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/usb/qmi_wwan.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1482,7 +1482,7 @@ static int qmi_wwan_probe(struct usb_interface *intf,
14821482
* different. Ignore the current interface if the number of endpoints
14831483
* equals the number for the diag interface (two).
14841484
*/
1485-
info = (void *)&id->driver_info;
1485+
info = (void *)id->driver_info;
14861486

14871487
if (info->data & QMI_WWAN_QUIRK_QUECTEL_DYNCFG) {
14881488
if (desc->bNumEndpoints == 2)

0 commit comments

Comments
 (0)