Skip to content

Commit 90f4a09

Browse files
billy-tsaialexandrebelloni
authored andcommitted
i3c: master: Remove the wrong place of reattach.
The reattach should be used when an I3C device has its address changed. But the modified place in this patch doesn't have the address changed of the newdev. This wrong reattach will reserve the same address slot twice and return unexpected -EBUSY when the bus find the duplicate device with diffent dynamic address. Signed-off-by: Billy Tsai <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]>
1 parent d4fa7d7 commit 90f4a09

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

drivers/i3c/master.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1911,10 +1911,6 @@ int i3c_master_add_i3c_dev_locked(struct i3c_master_controller *master,
19111911
i3c_master_free_i3c_dev(olddev);
19121912
}
19131913

1914-
ret = i3c_master_reattach_i3c_dev(newdev, old_dyn_addr);
1915-
if (ret)
1916-
goto err_detach_dev;
1917-
19181914
/*
19191915
* Depending on our previous state, the expected dynamic address might
19201916
* differ:

0 commit comments

Comments
 (0)