Skip to content

Commit 9188dba

Browse files
bentissJiri Kosina
authored andcommitted
HID: logitech-hidpp: add a module parameter to keep firmware gestures
The Logitech T650 used to report 3 fingers swipes to the up as a press on the Super key. When we switched the touchpad to the raw mode, we also disable such firmware gesture and some users may rely on it. Unfortunately, 3 finger swipes are still not supported in most of the Linux environments, which means that we disabled a feature of the touchpad. Allow users to revert the raw reporting mode and keep going with the firmware gestures by providing a new module parameter. Signed-off-by: Benjamin Tissoires <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent c1740d1 commit 9188dba

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

drivers/hid/hid-logitech-hidpp.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,11 @@ MODULE_LICENSE("GPL");
2828
MODULE_AUTHOR("Benjamin Tissoires <[email protected]>");
2929
MODULE_AUTHOR("Nestor Lopez Casado <[email protected]>");
3030

31+
static bool disable_raw_mode;
32+
module_param(disable_raw_mode, bool, 0644);
33+
MODULE_PARM_DESC(disable_raw_mode,
34+
"Disable Raw mode reporting for touchpads and keep firmware gestures.");
35+
3136
#define REPORT_ID_HIDPP_SHORT 0x10
3237
#define REPORT_ID_HIDPP_LONG 0x11
3338

@@ -1188,6 +1193,11 @@ static int hidpp_probe(struct hid_device *hdev, const struct hid_device_id *id)
11881193

11891194
hidpp->quirks = id->driver_data;
11901195

1196+
if (disable_raw_mode) {
1197+
hidpp->quirks &= ~HIDPP_QUIRK_CLASS_WTP;
1198+
hidpp->quirks &= ~HIDPP_QUIRK_DELAYED_INIT;
1199+
}
1200+
11911201
if (hidpp->quirks & HIDPP_QUIRK_CLASS_WTP) {
11921202
ret = wtp_allocate(hdev, id);
11931203
if (ret)

0 commit comments

Comments
 (0)