Skip to content

Commit 91a8252

Browse files
Dag Moxnesdavem330
authored andcommitted
rds: ib: Fix missing call to rds_ib_dev_put in rds_ib_setup_qp
The function rds_ib_setup_qp is calling rds_ib_get_client_data and should correspondingly call rds_ib_dev_put. This call was lost in the non-error path with the introduction of error handling done in commit 3b12f73 ("rds: ib: add error handle") Signed-off-by: Dag Moxnes <[email protected]> Reviewed-by: Håkon Bugge <[email protected]> Acked-by: Santosh Shilimkar <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 070204a commit 91a8252

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

net/rds/ib_cm.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -547,7 +547,7 @@ static int rds_ib_setup_qp(struct rds_connection *conn)
547547
rdsdebug("conn %p pd %p cq %p %p\n", conn, ic->i_pd,
548548
ic->i_send_cq, ic->i_recv_cq);
549549

550-
return ret;
550+
goto out;
551551

552552
sends_out:
553553
vfree(ic->i_sends);
@@ -572,6 +572,7 @@ static int rds_ib_setup_qp(struct rds_connection *conn)
572572
ic->i_send_cq = NULL;
573573
rds_ibdev_out:
574574
rds_ib_remove_conn(rds_ibdev, conn);
575+
out:
575576
rds_ib_dev_put(rds_ibdev);
576577

577578
return ret;

0 commit comments

Comments
 (0)