checkpatch: Add warnings for {smp_,}read_barrier_depends()

paulmck · paulmck · commit 91db2592e463 · 2017-12-05T11:57:55.000-08:00
Now that both smp_read_barrier_depends() and read_barrier_depends()
are being de-emphasized, warn if any are added.

Signed-off-by: Paul E. McKenney &lt;paulmck@linux.vnet.ibm.com&gt;
Cc: Andy Whitcroft &lt;apw@canonical.com&gt;
Cc: Joe Perches &lt;joe@perches.com&gt;
[ paulmck: Skipped checking files and handled whitespace per Joe Perches. ]
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
@@ -5586,6 +5586,12 @@ sub process {
 			}
 		}
 
+# check for smp_read_barrier_depends and read_barrier_depends
+		if (!$file && $line =~ /\b(smp_|)read_barrier_depends\s*\(/) {
+			WARN("READ_BARRIER_DEPENDS",
+			     "$1read_barrier_depends should only be used in READ_ONCE or DEC Alpha code\n" . $herecurr);
+		}
+
 # check of hardware specific defines
 		if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
 			CHK("ARCH_DEFINES",

Original file line number	Diff line number	Diff line change
`@@ -5586,6 +5586,12 @@ sub process {`
`5586`	`5586`	`}`
`5587`	`5587`	`}`
`5588`	`5588`
	`5589`	`+# check for smp_read_barrier_depends and read_barrier_depends`
	`5590`	`+ if (!$file && $line =~ /\b(smp_\|)read_barrier_depends\s*\(/) {`
	`5591`	`+ WARN("READ_BARRIER_DEPENDS",`
	`5592`	`+ "$1read_barrier_depends should only be used in READ_ONCE or DEC Alpha code\n" . $herecurr);`
	`5593`	`+ }`
	`5594`	`+`
`5589`	`5595`	`# check of hardware specific defines`
`5590`	`5596`	`if ($line =~ m@^.\s\#\sif.*\b(__i386__\|__powerpc64__\|__sun__\|__s390x__)\b@ && $realfile !~ m@include/asm-@) {`
`5591`	`5597`	`CHK("ARCH_DEFINES",`