Skip to content

Commit 92425c4

Browse files
Dan Carpenterdavem330
authored andcommitted
bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()
Smatch warns that: drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions() error: uninitialized symbol 'rc'. "rc" is either uninitialized or set to zero here so we can just remove the check. Fixes: 8c95f77 ("bnxt_en: add support for Flower based vxlan encap/decap offload") Signed-off-by: Dan Carpenter <[email protected]> Acked-by: Michael Chan <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent b9f2420 commit 92425c4

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,9 +148,6 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,
148148
}
149149
}
150150

151-
if (rc)
152-
return rc;
153-
154151
if (actions->flags & BNXT_TC_ACTION_FLAG_FWD) {
155152
if (actions->flags & BNXT_TC_ACTION_FLAG_TUNNEL_ENCAP) {
156153
/* dst_fid is PF's fid */
@@ -164,7 +161,7 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,
164161
}
165162
}
166163

167-
return rc;
164+
return 0;
168165
}
169166

170167
#define GET_KEY(flow_cmd, key_type) \

0 commit comments

Comments
 (0)