Skip to content

Commit 9276009

Browse files
fomichevAlexei Starovoitov
authored andcommitted
tools: ynl: Print xsk-features from the sample
In a similar fashion we do for the other bit masks. Fix mask parsing (>= vs >) while we are it. Signed-off-by: Stanislav Fomichev <[email protected]> Reviewed-by: Jakub Kicinski <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexei Starovoitov <[email protected]>
1 parent 48eb03d commit 9276009

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

tools/net/ynl/samples/netdev.c

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,23 @@ static void netdev_print_device(struct netdev_dev_get_rsp *d, unsigned int op)
3333
return;
3434

3535
printf("xdp-features (%llx):", d->xdp_features);
36-
for (int i = 0; d->xdp_features > 1U << i; i++) {
36+
for (int i = 0; d->xdp_features >= 1U << i; i++) {
3737
if (d->xdp_features & (1U << i))
3838
printf(" %s", netdev_xdp_act_str(1 << i));
3939
}
4040

4141
printf(" xdp-rx-metadata-features (%llx):", d->xdp_rx_metadata_features);
42-
for (int i = 0; d->xdp_rx_metadata_features > 1U << i; i++) {
42+
for (int i = 0; d->xdp_rx_metadata_features >= 1U << i; i++) {
4343
if (d->xdp_rx_metadata_features & (1U << i))
4444
printf(" %s", netdev_xdp_rx_metadata_str(1 << i));
4545
}
4646

47+
printf(" xsk-features (%llx):", d->xsk_features);
48+
for (int i = 0; d->xsk_features >= 1U << i; i++) {
49+
if (d->xsk_features & (1U << i))
50+
printf(" %s", netdev_xsk_flags_str(1 << i));
51+
}
52+
4753
printf(" xdp-zc-max-segs=%u", d->xdp_zc_max_segs);
4854

4955
name = netdev_op_str(op);

0 commit comments

Comments
 (0)