A/A Bonding: Miscellaneous module unload changes

The following changes are done as part of this change

1) destroy_workqueue() calls flush_workqueue() internally. Hence
   removed calling flush_workqueue() explicitly from the Resilient
   RDMAIP module.

2) Moved unregister_ib_client() to after calling rdmaip_restore_ips().
   Resilient RDMAIP module IB client callback will be invoked by the
   IB core informs about the device removal for all the IB core clients.
   In the callback,  rdmaip_dev structure will be deallocated. It is
   good to move the deallocation after rdmaip_restpore_ips() to
   avoid crashed due to access to the deallocated memory.

3) In rdmaip_init() function, if creating rdmaip_garps_wq fails,
   destroy_workqueue(rdmaip_wq) is called in the failure path.
   This is not needed as rdmaip_cleanup() takes care of this.

Orabug: 29781216

Signed-off-by: Sudhakar Dindukurti <[email protected]>
Reviewed-by: Yuval Shaia <[email protected]>
Signed-off-by: Somasundaram Krishnasamy <[email protected]>

Author: sudhakar-dindukurti

drivers/infiniband/core/rdmaip.c

@@ -2541,13 +2541,11 @@ void rdmaip_destroy_workqs(void)
 
 	if (rdmaip_init_flag & RDMAIP_IP_WQ_CREATED) {
 		cancel_delayed_work_sync(&riif_dlywork);
-		flush_workqueue(rdmaip_wq);
 		destroy_workqueue(rdmaip_wq);
 		rdmaip_init_flag &= ~RDMAIP_IP_WQ_CREATED;
 	}
 
 	if (rdmaip_init_flag & RDMAIP_GARPS_WQ_CREATED) {
-		flush_workqueue(rdmaip_garps_wq);
 		destroy_workqueue(rdmaip_garps_wq);
 		rdmaip_init_flag &= ~RDMAIP_GARPS_WQ_CREATED;
 	}
@@ -2759,17 +2757,17 @@ void rdmaip_cleanup(void)
 
 	rdmaip_destroy_workqs();
 
-	if (rdmaip_init_flag & RDMAIP_IB_REG) {
-		ib_unregister_client(&rdmaip_client);
-		rdmaip_init_flag &= ~RDMAIP_IB_REG;
-	}
-
 	/*
 	 * After this point, no rdmaip callbacks will be called
 	 * by other frameworks. Clean up all the resources.
 	 */
 	rdmaip_restore_ip_addresses();
 
+	if (rdmaip_init_flag & RDMAIP_IB_REG) {
+		ib_unregister_client(&rdmaip_client);
+		rdmaip_init_flag &= ~RDMAIP_IB_REG;
+	}
+
 	if (rdmaip_init_flag & RDMAIP_REG_NET_SYSCTL) {
 		unregister_net_sysctl_table(rdmaip_sysctl_hdr);
 		rdmaip_init_flag &= ~RDMAIP_REG_NET_SYSCTL;
@@ -2894,7 +2892,6 @@ int rdmaip_init(void)
 	rdmaip_garps_wq = create_workqueue("rdmaip_garps");
 	if (!rdmaip_garps_wq) {
 		rdmaip_cleanup();
-		destroy_workqueue(rdmaip_wq);
 		return -ENOMEM;
 	}
 	rdmaip_init_flag |= RDMAIP_GARPS_WQ_CREATED;