net/rds: reduce memory footprint during ib_post_recv in IB transport

The RDS IB large fragment size feature requires order 2 memory allocations
and it introduces memory pressure in the allocation system. Thus, this
patch implements large fragment size support in ib_post_recv with N sge. As
of today, RDS has an assumption that each IB received work request has only
two SGEs. This patch removes this assumption and uses various SGE to
support large fragment size.

Orabug: 27339270

Signed-off-by: Wei Lin Guay <[email protected]>
Reviewed-by: Håkon Bugge <[email protected]>
Tested-by: Shih-Yu Huang <[email protected]>
Acked-by: Santosh Shilimkar <[email protected]>

(cherry picked from commit 05af55886c8f3e092c2f222dd0ed73dbdfe59de5)

Compilation errors:
	    net/rds/ib_cm.c

	    Commit 7d76b09d2274 (“net/rds Making RDS compile with 4.14
	    APIs (untested) & dropping iWarp") renamed "attr" to
	    "qp_attr". Had to fix.

	    net/rds/ib_recv.{ch}

	    Commit d45c268a22ca ("RDS: make sure we post recv
	    buffers") changes the signature and introduces "int
	    can_wait". Reworked that to become equal upstream.

	    The cherry picked commit did also include the fix in
	    9bf627b ("rds: ib: Fix NULL pointer dereference in
	    debug code"), hence, had to remove the rdsdebug() call
	    after ib_post_recv().

(cherry picked from commit bacbc2db34068892f6a1585801562227edee0b44)
(cherry picked from commit 30650f2d7475db8865a40541af0017a5b7202baa)
Signed-off-by: Somasundaram Krishnasamy <[email protected]>

Author: Wei Lin Guay

net/rds/ib.c

@@ -2831,32 +2831,37 @@ int rds_ib_inc_to_skb(struct rds_incoming *inc, struct sk_buff *skb)
 	int i;
 	struct rds_ib_incoming *ibinc;
 	struct rds_page_frag *ibfrag;
+	struct scatterlist *sg;
 
 	/* pull out initial pointers */
 	ibinc  = container_of(inc, struct rds_ib_incoming, ii_inc);
 	ibfrag = list_entry(ibinc->ii_frags.next, struct rds_page_frag, f_item);
 	len    = be32_to_cpu(inc->i_hdr.h_len);
+	sg     = ibfrag->f_sg;
 	slen   = len;
 	i      = 0;
 
 	/* run through the entire ib fragment list and save off the buffers */
 	while (NULL != ibfrag && slen > 0) {
 		/* one to one mapping of frags to sg structures */
 		frag = &skb_shinfo(skb)->frags[i];
-
 		/* save off all the sg pieces to the skb frags we are creating */
-		frag->size        = ibfrag->f_sg.length;
-		frag->page_offset = ibfrag->f_sg.offset;
-		frag->page.p      = sg_page(&ibfrag->f_sg);
+		frag->size        = sg->length;
+		frag->page_offset = sg->offset;
+		frag->page.p      = sg_page(sg);
 
 		/* AA:  do we need to bump up the page reference */
 		/* get_page(frag->page); */
 
 		/* dec the amount of data we are consuming */
 		slen -= frag->size;
 
-		/* bump to the next entry */
-		ibfrag = list_entry(ibfrag->f_item.next, struct rds_page_frag, f_item);
+		sg  = sg_next(sg);
+		if (!sg) {
+			/* bump to the next entry */
+			ibfrag = list_entry(ibfrag->f_item.next, struct rds_page_frag, f_item);
+			sg = ibfrag->f_sg;
+		}
 		i++;
 
 		/* for now we will only have a single chain of fragments in the skb */

net/rds/ib.h

@@ -50,6 +50,8 @@
 
 #define RDS_WC_MAX 32
 
+#define NUM_RDS_RECV_SG	(PAGE_ALIGN(RDS_MAX_FRAG_SIZE) / PAGE_SIZE)
+
 #define	RDS_IB_CLEAN_CACHE	1
 
 #define RDS_IB_DEFAULT_FREG_PORT_NUM	1
@@ -65,7 +67,7 @@ extern struct list_head rds_ib_devices;
 struct rds_page_frag {
 	struct list_head	f_item;
 	struct list_head	f_cache_entry;
-	struct scatterlist	f_sg;
+	struct scatterlist	f_sg[NUM_RDS_RECV_SG];
 };
 
 struct rds_ib_incoming {
@@ -114,7 +116,7 @@ struct rds_ib_recv_work {
 	struct rds_ib_incoming	*r_ibinc;
 	struct rds_page_frag	*r_frag;
 	struct ib_recv_wr	r_wr;
-	struct ib_sge		r_sge[2];
+	struct ib_sge		r_sge[RDS_IB_MAX_SGE];
 	struct rds_ib_connection	*r_ic;
 	int				r_posted;
 };
@@ -629,7 +631,7 @@ int rds_ib_recv_path(struct rds_conn_path *cp);
 int rds_ib_recv_alloc_caches(struct rds_ib_connection *ic);
 void rds_ib_recv_free_caches(struct rds_ib_connection *ic);
 void rds_ib_recv_rebuild_caches(struct rds_ib_connection *ic);
-void rds_ib_recv_refill(struct rds_connection *conn, int prefill, int can_wait);
+void rds_ib_recv_refill(struct rds_connection *conn, int prefill, gfp_t gfp);
 void rds_ib_inc_free(struct rds_incoming *inc);
 int rds_ib_inc_copy_to_user(struct rds_incoming *inc, struct iov_iter *to);
 void rds_ib_recv_cqe_handler(struct rds_ib_connection *ic,

net/rds/ib_cm.c

@@ -767,7 +767,7 @@ static int rds_ib_setup_qp(struct rds_connection *conn)
 	qp_attr.cap.max_send_wr = ic->i_send_ring.w_nr + 1 + mr_reg;
 	qp_attr.cap.max_recv_wr = ic->i_recv_ring.w_nr + 1;
 	qp_attr.cap.max_send_sge = rds_ibdev->max_sge;
-	qp_attr.cap.max_recv_sge = RDS_IB_RECV_SGE;
+	qp_attr.cap.max_recv_sge = rds_ibdev->max_sge;
 	qp_attr.sq_sig_type = IB_SIGNAL_REQ_WR;
 	qp_attr.qp_type = IB_QPT_RC;
 	qp_attr.send_cq = ic->i_scq;