Skip to content

Commit 94a72b3

Browse files
NicolasDichteldavem330
authored andcommitted
bridge/mdb: remove wrong use of NLM_F_MULTI
NLM_F_MULTI must be used only when a NLMSG_DONE message is sent at the end. In fact, NLMSG_DONE is sent only at the end of a dump. Libraries like libnl will wait forever for NLMSG_DONE. Fixes: 949f1e3 ("bridge: mdb: notify on router port add and del") CC: Nikolay Aleksandrov <[email protected]> Signed-off-by: Nicolas Dichtel <[email protected]> Acked-by: Nikolay Aleksandrov <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent c8dc559 commit 94a72b3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/bridge/br_mdb.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,7 @@ static int nlmsg_populate_rtr_fill(struct sk_buff *skb,
437437
struct nlmsghdr *nlh;
438438
struct nlattr *nest;
439439

440-
nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), NLM_F_MULTI);
440+
nlh = nlmsg_put(skb, pid, seq, type, sizeof(*bpm), 0);
441441
if (!nlh)
442442
return -EMSGSIZE;
443443

0 commit comments

Comments
 (0)