Skip to content

Commit 94bfaaf

Browse files
IronShendavem330
authored andcommitted
net: hns3: Fix a loop index error of tqp statistics query
An error loop index was used while querying statistics data of tqps, which may cause call trace. Fixes: 496d03e ("net: hns3: Add Ethtool support to HNS3 driver") Signed-off-by: Jian Shen <[email protected]> Signed-off-by: Peng Li <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent d2a5dca commit 94bfaaf

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -458,22 +458,22 @@ static u64 *hns3_get_stats_tqps(struct hnae3_handle *handle, u64 *data)
458458
struct hnae3_knic_private_info *kinfo = &handle->kinfo;
459459
struct hns3_enet_ring *ring;
460460
u8 *stat;
461-
u32 i;
461+
int i, j;
462462

463463
/* get stats for Tx */
464464
for (i = 0; i < kinfo->num_tqps; i++) {
465465
ring = nic_priv->ring_data[i].ring;
466-
for (i = 0; i < HNS3_TXQ_STATS_COUNT; i++) {
467-
stat = (u8 *)ring + hns3_txq_stats[i].stats_offset;
466+
for (j = 0; j < HNS3_TXQ_STATS_COUNT; j++) {
467+
stat = (u8 *)ring + hns3_txq_stats[j].stats_offset;
468468
*data++ = *(u64 *)stat;
469469
}
470470
}
471471

472472
/* get stats for Rx */
473473
for (i = 0; i < kinfo->num_tqps; i++) {
474474
ring = nic_priv->ring_data[i + kinfo->num_tqps].ring;
475-
for (i = 0; i < HNS3_RXQ_STATS_COUNT; i++) {
476-
stat = (u8 *)ring + hns3_rxq_stats[i].stats_offset;
475+
for (j = 0; j < HNS3_RXQ_STATS_COUNT; j++) {
476+
stat = (u8 *)ring + hns3_rxq_stats[j].stats_offset;
477477
*data++ = *(u64 *)stat;
478478
}
479479
}

0 commit comments

Comments
 (0)