Skip to content

Commit 9525d69

Browse files
GustavoARSilvadavem330
authored andcommitted
net: plip: mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114893 Addresses-Coverity-ID: 114894 Addresses-Coverity-ID: 114895 Addresses-Coverity-ID: 114896 Addresses-Coverity-ID: 114897 Addresses-Coverity-ID: 114898 Addresses-Coverity-ID: 114899 Addresses-Coverity-ID: 114900 Addresses-Coverity-ID: 114901 Addresses-Coverity-ID: 114902 Addresses-Coverity-ID: 114903 Addresses-Coverity-ID: 114904 Addresses-Coverity-ID: 114905 Signed-off-by: Gustavo A. R. Silva <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 35e00da commit 9525d69

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

drivers/net/plip/plip.c

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -502,6 +502,7 @@ plip_receive(unsigned short nibble_timeout, struct net_device *dev,
502502
*data_p = (c0 >> 3) & 0x0f;
503503
write_data (dev, 0x10); /* send ACK */
504504
*ns_p = PLIP_NB_1;
505+
/* fall through */
505506

506507
case PLIP_NB_1:
507508
cx = nibble_timeout;
@@ -597,6 +598,7 @@ plip_receive_packet(struct net_device *dev, struct net_local *nl,
597598
printk(KERN_DEBUG "%s: receive start\n", dev->name);
598599
rcv->state = PLIP_PK_LENGTH_LSB;
599600
rcv->nibble = PLIP_NB_BEGIN;
601+
/* fall through */
600602

601603
case PLIP_PK_LENGTH_LSB:
602604
if (snd->state != PLIP_PK_DONE) {
@@ -617,6 +619,7 @@ plip_receive_packet(struct net_device *dev, struct net_local *nl,
617619
return TIMEOUT;
618620
}
619621
rcv->state = PLIP_PK_LENGTH_MSB;
622+
/* fall through */
620623

621624
case PLIP_PK_LENGTH_MSB:
622625
if (plip_receive(nibble_timeout, dev,
@@ -639,6 +642,7 @@ plip_receive_packet(struct net_device *dev, struct net_local *nl,
639642
rcv->state = PLIP_PK_DATA;
640643
rcv->byte = 0;
641644
rcv->checksum = 0;
645+
/* fall through */
642646

643647
case PLIP_PK_DATA:
644648
lbuf = rcv->skb->data;
@@ -651,6 +655,7 @@ plip_receive_packet(struct net_device *dev, struct net_local *nl,
651655
rcv->checksum += lbuf[--rcv->byte];
652656
} while (rcv->byte);
653657
rcv->state = PLIP_PK_CHECKSUM;
658+
/* fall through */
654659

655660
case PLIP_PK_CHECKSUM:
656661
if (plip_receive(nibble_timeout, dev,
@@ -663,6 +668,7 @@ plip_receive_packet(struct net_device *dev, struct net_local *nl,
663668
return ERROR;
664669
}
665670
rcv->state = PLIP_PK_DONE;
671+
/* fall through */
666672

667673
case PLIP_PK_DONE:
668674
/* Inform the upper layer for the arrival of a packet. */
@@ -708,6 +714,7 @@ plip_send(unsigned short nibble_timeout, struct net_device *dev,
708714
case PLIP_NB_BEGIN:
709715
write_data (dev, data & 0x0f);
710716
*ns_p = PLIP_NB_1;
717+
/* fall through */
711718

712719
case PLIP_NB_1:
713720
write_data (dev, 0x10 | (data & 0x0f));
@@ -722,6 +729,7 @@ plip_send(unsigned short nibble_timeout, struct net_device *dev,
722729
}
723730
write_data (dev, 0x10 | (data >> 4));
724731
*ns_p = PLIP_NB_2;
732+
/* fall through */
725733

726734
case PLIP_NB_2:
727735
write_data (dev, (data >> 4));
@@ -810,6 +818,7 @@ plip_send_packet(struct net_device *dev, struct net_local *nl,
810818
&snd->nibble, snd->length.b.lsb))
811819
return TIMEOUT;
812820
snd->state = PLIP_PK_LENGTH_MSB;
821+
/* fall through */
813822

814823
case PLIP_PK_LENGTH_MSB:
815824
if (plip_send(nibble_timeout, dev,
@@ -818,6 +827,7 @@ plip_send_packet(struct net_device *dev, struct net_local *nl,
818827
snd->state = PLIP_PK_DATA;
819828
snd->byte = 0;
820829
snd->checksum = 0;
830+
/* fall through */
821831

822832
case PLIP_PK_DATA:
823833
do {
@@ -829,6 +839,7 @@ plip_send_packet(struct net_device *dev, struct net_local *nl,
829839
snd->checksum += lbuf[--snd->byte];
830840
} while (snd->byte);
831841
snd->state = PLIP_PK_CHECKSUM;
842+
/* fall through */
832843

833844
case PLIP_PK_CHECKSUM:
834845
if (plip_send(nibble_timeout, dev,
@@ -839,6 +850,7 @@ plip_send_packet(struct net_device *dev, struct net_local *nl,
839850
dev_kfree_skb(snd->skb);
840851
dev->stats.tx_packets++;
841852
snd->state = PLIP_PK_DONE;
853+
/* fall through */
842854

843855
case PLIP_PK_DONE:
844856
/* Close the connection */
@@ -927,6 +939,7 @@ plip_interrupt(void *dev_id)
927939
switch (nl->connection) {
928940
case PLIP_CN_CLOSING:
929941
netif_wake_queue (dev);
942+
/* fall through */
930943
case PLIP_CN_NONE:
931944
case PLIP_CN_SEND:
932945
rcv->state = PLIP_PK_TRIGGER;

0 commit comments

Comments
 (0)