Skip to content

Commit 9539303

Browse files
committed
Merge tag 'xtensa-20200410' of git://github.com/jcmvbkbc/linux-xtensa
Pull xtensa updates from Max Filippov: - replace setup_irq() by request_irq() - cosmetic fixes in xtensa Kconfig and boot/Makefile * tag 'xtensa-20200410' of git://github.com/jcmvbkbc/linux-xtensa: arch/xtensa: fix grammar in Kconfig help text xtensa: remove meaningless export ccflags-y xtensa: replace setup_irq() by request_irq()
2 parents e6383b1 + 70cbddb commit 9539303

File tree

4 files changed

+8
-15
lines changed

4 files changed

+8
-15
lines changed

arch/xtensa/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ config XTENSA_VARIANT_CUSTOM_NAME
122122
help
123123
Provide the name of a custom Xtensa processor variant.
124124
This CORENAME selects arch/xtensa/variant/CORENAME.
125-
Dont forget you have to select MMU if you have one.
125+
Don't forget you have to select MMU if you have one.
126126

127127
config XTENSA_VARIANT_NAME
128128
string

arch/xtensa/boot/Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ HOSTFLAGS += -Iarch/$(ARCH)/boot/include
1414

1515
BIG_ENDIAN := $(shell echo __XTENSA_EB__ | $(CC) -E - | grep -v "\#")
1616

17-
export ccflags-y
1817
export BIG_ENDIAN
1918

2019
subdir-y := lib

arch/xtensa/kernel/smp.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,16 +53,12 @@ static void system_flush_invalidate_dcache_range(unsigned long start,
5353
#define IPI_IRQ 0
5454

5555
static irqreturn_t ipi_interrupt(int irq, void *dev_id);
56-
static struct irqaction ipi_irqaction = {
57-
.handler = ipi_interrupt,
58-
.flags = IRQF_PERCPU,
59-
.name = "ipi",
60-
};
6156

6257
void ipi_init(void)
6358
{
6459
unsigned irq = irq_create_mapping(NULL, IPI_IRQ);
65-
setup_irq(irq, &ipi_irqaction);
60+
if (request_irq(irq, ipi_interrupt, IRQF_PERCPU, "ipi", NULL))
61+
pr_err("Failed to request irq %u (ipi)\n", irq);
6662
}
6763

6864
static inline unsigned int get_core_count(void)

arch/xtensa/kernel/time.c

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -128,12 +128,6 @@ static irqreturn_t timer_interrupt(int irq, void *dev_id)
128128
return IRQ_HANDLED;
129129
}
130130

131-
static struct irqaction timer_irqaction = {
132-
.handler = timer_interrupt,
133-
.flags = IRQF_TIMER,
134-
.name = "timer",
135-
};
136-
137131
void local_timer_setup(unsigned cpu)
138132
{
139133
struct ccount_timer *timer = &per_cpu(ccount_timer, cpu);
@@ -184,6 +178,8 @@ static inline void calibrate_ccount(void)
184178

185179
void __init time_init(void)
186180
{
181+
int irq;
182+
187183
of_clk_init(NULL);
188184
#ifdef CONFIG_XTENSA_CALIBRATE_CCOUNT
189185
pr_info("Calibrating CPU frequency ");
@@ -199,7 +195,9 @@ void __init time_init(void)
199195
__func__);
200196
clocksource_register_hz(&ccount_clocksource, ccount_freq);
201197
local_timer_setup(0);
202-
setup_irq(this_cpu_ptr(&ccount_timer)->evt.irq, &timer_irqaction);
198+
irq = this_cpu_ptr(&ccount_timer)->evt.irq;
199+
if (request_irq(irq, timer_interrupt, IRQF_TIMER, "timer", NULL))
200+
pr_err("Failed to request irq %d (timer)\n", irq);
203201
sched_clock_register(ccount_sched_clock_read, 32, ccount_freq);
204202
timer_probe();
205203
}

0 commit comments

Comments
 (0)