Skip to content

Commit 95ce7f4

Browse files
Muchun Songjfvogel
authored andcommitted
mm: rename unlock_page_lruvec{_irq, _irqrestore} to lruvec_unlock{_irq, _irqrestore}
It is weird to use folio_lruvec_lock() variants and unlock_page_lruvec() variants together, e.g. locking folio and unlocking page. So rename unlock_page_lruvec{_irq, _irqrestore} to lruvec_unlock{_irq, _irqrestore}. Signed-off-by: Muchun Song <[email protected]> Acked-by: Roman Gushchin <[email protected]> Link: https://lore.kernel.org/all/[email protected]/ Orabug: 37405594 Conflicts: include/linux/memcontrol.h mm/compaction.c mm/mlock.c mm/vmscan.c mm/huge_memory.c mm/swap.c (Due to the presence of following commits in UEK-8: i. 'commit 1c06b6a mm: compaction: fix the possible deadlock when isolating hugetlb pages' ii. 'commit 56ae0bb mm: compaction: convert to use a folio in isolate_migratepages_block()' iii. 'commit 2bd7f62 mm: mlock: use folios_put() in mlock_folio_batch()' iv. 'commit 90d0721 mm: mlock: use folios and a folio batch internally' v. 'commit 018ee47 mm: multi-gen LRU: exploit locality in rmap' vi. 'commit f2d2739 mm/swap: Add folio_activate()' vii. 'commit c010d47 mm: thp: split huge page to any lower order pages' viii. 'commit 99fbb6b mm: make folios_put() the basis of release_pages()' ix. 'commit ab5e653 mm/swap: convert release_pages to use a folio internally' x. 'commit f1ee018 mm: use __page_cache_release() in folios_put()' Signed-off-by: Imran Khan <[email protected]> Reviewed-by: Kamalesh Babulal <[email protected]>
1 parent f4fe741 commit 95ce7f4

File tree

6 files changed

+22
-22
lines changed

6 files changed

+22
-22
lines changed

include/linux/memcontrol.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1561,17 +1561,17 @@ static inline struct lruvec *parent_lruvec(struct lruvec *lruvec)
15611561
return mem_cgroup_lruvec(memcg, lruvec_pgdat(lruvec));
15621562
}
15631563

1564-
static inline void unlock_page_lruvec(struct lruvec *lruvec)
1564+
static inline void lruvec_unlock(struct lruvec *lruvec)
15651565
{
15661566
spin_unlock(&lruvec->lru_lock);
15671567
}
15681568

1569-
static inline void unlock_page_lruvec_irq(struct lruvec *lruvec)
1569+
static inline void lruvec_unlock_irq(struct lruvec *lruvec)
15701570
{
15711571
spin_unlock_irq(&lruvec->lru_lock);
15721572
}
15731573

1574-
static inline void unlock_page_lruvec_irqrestore(struct lruvec *lruvec,
1574+
static inline void lruvec_unlock_irqrestore(struct lruvec *lruvec,
15751575
unsigned long flags)
15761576
{
15771577
spin_unlock_irqrestore(&lruvec->lru_lock, flags);
@@ -1593,7 +1593,7 @@ static inline struct lruvec *folio_lruvec_relock_irq(struct folio *folio,
15931593
if (folio_matches_lruvec(folio, locked_lruvec))
15941594
return locked_lruvec;
15951595

1596-
unlock_page_lruvec_irq(locked_lruvec);
1596+
lruvec_unlock_irq(locked_lruvec);
15971597
}
15981598

15991599
return folio_lruvec_lock_irq(folio);
@@ -1607,7 +1607,7 @@ static inline void folio_lruvec_relock_irqsave(struct folio *folio,
16071607
if (folio_matches_lruvec(folio, *lruvecp))
16081608
return;
16091609

1610-
unlock_page_lruvec_irqrestore(*lruvecp, *flags);
1610+
lruvec_unlock_irqrestore(*lruvecp, *flags);
16111611
}
16121612

16131613
*lruvecp = folio_lruvec_lock_irqsave(folio, flags);

mm/compaction.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -981,7 +981,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
981981
*/
982982
if (!(low_pfn % COMPACT_CLUSTER_MAX)) {
983983
if (locked) {
984-
unlock_page_lruvec_irqrestore(locked, flags);
984+
lruvec_unlock_irqrestore(locked, flags);
985985
locked = NULL;
986986
}
987987

@@ -1032,7 +1032,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
10321032
}
10331033
/* for alloc_contig case */
10341034
if (locked) {
1035-
unlock_page_lruvec_irqrestore(locked, flags);
1035+
lruvec_unlock_irqrestore(locked, flags);
10361036
locked = NULL;
10371037
}
10381038

@@ -1124,7 +1124,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
11241124
if (unlikely(__PageMovable(page)) &&
11251125
!PageIsolated(page)) {
11261126
if (locked) {
1127-
unlock_page_lruvec_irqrestore(locked, flags);
1127+
lruvec_unlock_irqrestore(locked, flags);
11281128
locked = NULL;
11291129
}
11301130

@@ -1229,7 +1229,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
12291229
/* If we already hold the lock, we can skip some rechecking */
12301230
if (lruvec != locked) {
12311231
if (locked)
1232-
unlock_page_lruvec_irqrestore(locked, flags);
1232+
lruvec_unlock_irqrestore(locked, flags);
12331233

12341234
compact_lock_irqsave(&lruvec->lru_lock, &flags, cc);
12351235
locked = lruvec;
@@ -1297,7 +1297,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
12971297
isolate_fail_put:
12981298
/* Avoid potential deadlock in freeing page under lru_lock */
12991299
if (locked) {
1300-
unlock_page_lruvec_irqrestore(locked, flags);
1300+
lruvec_unlock_irqrestore(locked, flags);
13011301
locked = NULL;
13021302
}
13031303
folio_put(folio);
@@ -1313,7 +1313,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
13131313
*/
13141314
if (nr_isolated) {
13151315
if (locked) {
1316-
unlock_page_lruvec_irqrestore(locked, flags);
1316+
lruvec_unlock_irqrestore(locked, flags);
13171317
locked = NULL;
13181318
}
13191319
putback_movable_pages(&cc->migratepages);
@@ -1345,7 +1345,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
13451345

13461346
isolate_abort:
13471347
if (locked)
1348-
unlock_page_lruvec_irqrestore(locked, flags);
1348+
lruvec_unlock_irqrestore(locked, flags);
13491349
if (folio) {
13501350
folio_set_lru(folio);
13511351
folio_put(folio);

mm/huge_memory.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3241,7 +3241,7 @@ static void __split_huge_page(struct page *page, struct list_head *list,
32413241

32423242
folio_set_order(new_folio, new_order);
32433243
}
3244-
unlock_page_lruvec(lruvec);
3244+
lruvec_unlock(lruvec);
32453245
/* Caller disabled irqs, so they are still disabled here */
32463246

32473247
split_page_owner(head, order, new_order);

mm/mlock.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ static void mlock_folio_batch(struct folio_batch *fbatch)
205205
}
206206

207207
if (lruvec)
208-
unlock_page_lruvec_irq(lruvec);
208+
lruvec_unlock_irq(lruvec);
209209
folios_put(fbatch);
210210
}
211211

mm/swap.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ static void page_cache_release(struct folio *folio)
9191

9292
__page_cache_release(folio, &lruvec, &flags);
9393
if (lruvec)
94-
unlock_page_lruvec_irqrestore(lruvec, flags);
94+
lruvec_unlock_irqrestore(lruvec, flags);
9595
}
9696

9797
void __folio_put(struct folio *folio)
@@ -202,7 +202,7 @@ static void folio_batch_move_lru(struct folio_batch *fbatch, move_fn_t move_fn)
202202
}
203203

204204
if (lruvec)
205-
unlock_page_lruvec_irqrestore(lruvec, flags);
205+
lruvec_unlock_irqrestore(lruvec, flags);
206206
folios_put(fbatch);
207207
}
208208

@@ -374,7 +374,7 @@ void folio_activate(struct folio *folio)
374374

375375
lruvec = folio_lruvec_lock_irq(folio);
376376
lru_activate(lruvec, folio);
377-
unlock_page_lruvec_irq(lruvec);
377+
lruvec_unlock_irq(lruvec);
378378
folio_set_lru(folio);
379379
}
380380
#endif
@@ -952,7 +952,7 @@ void folios_put_refs(struct folio_batch *folios, unsigned int *refs)
952952

953953
if (folio_is_zone_device(folio)) {
954954
if (lruvec) {
955-
unlock_page_lruvec_irqrestore(lruvec, flags);
955+
lruvec_unlock_irqrestore(lruvec, flags);
956956
lruvec = NULL;
957957
}
958958
if (put_devmap_managed_folio_refs(folio, nr_refs))
@@ -968,7 +968,7 @@ void folios_put_refs(struct folio_batch *folios, unsigned int *refs)
968968
/* hugetlb has its own memcg */
969969
if (folio_test_hugetlb(folio)) {
970970
if (lruvec) {
971-
unlock_page_lruvec_irqrestore(lruvec, flags);
971+
lruvec_unlock_irqrestore(lruvec, flags);
972972
lruvec = NULL;
973973
}
974974
free_huge_folio(folio);
@@ -982,7 +982,7 @@ void folios_put_refs(struct folio_batch *folios, unsigned int *refs)
982982
j++;
983983
}
984984
if (lruvec)
985-
unlock_page_lruvec_irqrestore(lruvec, flags);
985+
lruvec_unlock_irqrestore(lruvec, flags);
986986
if (!j) {
987987
folio_batch_reinit(folios);
988988
return;

mm/vmscan.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1781,7 +1781,7 @@ bool folio_isolate_lru(struct folio *folio)
17811781
folio_get(folio);
17821782
lruvec = folio_lruvec_lock_irq(folio);
17831783
lruvec_del_folio(lruvec, folio);
1784-
unlock_page_lruvec_irq(lruvec);
1784+
lruvec_unlock_irq(lruvec);
17851785
ret = true;
17861786
}
17871787

@@ -7607,7 +7607,7 @@ void check_move_unevictable_folios(struct folio_batch *fbatch)
76077607
if (lruvec) {
76087608
__count_vm_events(UNEVICTABLE_PGRESCUED, pgrescued);
76097609
__count_vm_events(UNEVICTABLE_PGSCANNED, pgscanned);
7610-
unlock_page_lruvec_irq(lruvec);
7610+
lruvec_unlock_irq(lruvec);
76117611
} else if (pgscanned) {
76127612
count_vm_events(UNEVICTABLE_PGSCANNED, pgscanned);
76137613
}

0 commit comments

Comments
 (0)