Skip to content

Commit 965adae

Browse files
committed
selftests/net: packetdrill: more xfail changes (and a correction)
Recent change to add more cases to XFAIL has a broken regex, the matching needs a real regex not a glob pattern. While at it add the cases Willem pointed out during review. Fixes: 3030e3d ("selftests/net: packetdrill: make tcp buf limited timing tests benign") Reviewed-by: Willem de Bruijn <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 59e00e8 commit 965adae

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

tools/testing/selftests/net/packetdrill/ksft_runner.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,13 @@ if [[ -n "${KSFT_MACHINE_SLOW}" ]]; then
3939
# xfail tests that are known flaky with dbg config, not fixable.
4040
# still run them for coverage (and expect 100% pass without dbg).
4141
declare -ar xfail_list=(
42+
"tcp_eor_no-coalesce-retrans.pkt"
4243
"tcp_fast_recovery_prr-ss.*.pkt"
44+
"tcp_slow_start_slow-start-after-win-update.pkt"
4345
"tcp_timestamping.*.pkt"
4446
"tcp_user_timeout_user-timeout-probe.pkt"
4547
"tcp_zerocopy_epoll_.*.pkt"
46-
"tcp_tcp_info_tcp-info-*-limited.pkt"
48+
"tcp_tcp_info_tcp-info-.*-limited.pkt"
4749
)
4850
readonly xfail_regex="^($(printf '%s|' "${xfail_list[@]}"))$"
4951
[[ "$script" =~ ${xfail_regex} ]] && failfunc=ktap_test_xfail

0 commit comments

Comments
 (0)