Skip to content

Commit 965b652

Browse files
damien-lemoalaxboe
authored andcommitted
block: Expose queue nr_zones in sysfs
Expose through sysfs the nr_zones field of struct request_queue. Exposing this value helps in debugging disk issues as well as facilitating scripts based use of the disk (e.g. blktests). For zoned block devices, the nr_zones field indicates the total number of zones of the device calculated using the known disk capacity and zone size. This number of zones is always 0 for regular block devices. Since nr_zones is defined conditionally with CONFIG_BLK_DEV_ZONED, introduce the blk_queue_nr_zones() function to return the correct value for any device, regardless if CONFIG_BLK_DEV_ZONED is set. Reviewed-by: Christoph Hellwig <[email protected]> Reviewed-by: Hannes Reinecke <[email protected]> Signed-off-by: Damien Le Moal <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent a2d6b3a commit 965b652

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

block/blk-sysfs.c

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -300,6 +300,11 @@ static ssize_t queue_zoned_show(struct request_queue *q, char *page)
300300
}
301301
}
302302

303+
static ssize_t queue_nr_zones_show(struct request_queue *q, char *page)
304+
{
305+
return queue_var_show(blk_queue_nr_zones(q), page);
306+
}
307+
303308
static ssize_t queue_nomerges_show(struct request_queue *q, char *page)
304309
{
305310
return queue_var_show((blk_queue_nomerges(q) << 1) |
@@ -637,6 +642,11 @@ static struct queue_sysfs_entry queue_zoned_entry = {
637642
.show = queue_zoned_show,
638643
};
639644

645+
static struct queue_sysfs_entry queue_nr_zones_entry = {
646+
.attr = {.name = "nr_zones", .mode = 0444 },
647+
.show = queue_nr_zones_show,
648+
};
649+
640650
static struct queue_sysfs_entry queue_nomerges_entry = {
641651
.attr = {.name = "nomerges", .mode = 0644 },
642652
.show = queue_nomerges_show,
@@ -727,6 +737,7 @@ static struct attribute *default_attrs[] = {
727737
&queue_write_zeroes_max_entry.attr,
728738
&queue_nonrot_entry.attr,
729739
&queue_zoned_entry.attr,
740+
&queue_nr_zones_entry.attr,
730741
&queue_nomerges_entry.attr,
731742
&queue_rq_affinity_entry.attr,
732743
&queue_iostats_entry.attr,

include/linux/blkdev.h

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -811,6 +811,11 @@ static inline unsigned int blk_queue_zone_sectors(struct request_queue *q)
811811
}
812812

813813
#ifdef CONFIG_BLK_DEV_ZONED
814+
static inline unsigned int blk_queue_nr_zones(struct request_queue *q)
815+
{
816+
return blk_queue_is_zoned(q) ? q->nr_zones : 0;
817+
}
818+
814819
static inline unsigned int blk_queue_zone_no(struct request_queue *q,
815820
sector_t sector)
816821
{
@@ -826,6 +831,11 @@ static inline bool blk_queue_zone_is_seq(struct request_queue *q,
826831
return false;
827832
return test_bit(blk_queue_zone_no(q, sector), q->seq_zones_bitmap);
828833
}
834+
#else /* CONFIG_BLK_DEV_ZONED */
835+
static inline unsigned int blk_queue_nr_zones(struct request_queue *q)
836+
{
837+
return 0;
838+
}
829839
#endif /* CONFIG_BLK_DEV_ZONED */
830840

831841
static inline bool rq_is_sync(struct request *rq)

0 commit comments

Comments
 (0)