Skip to content

Commit 967c9ec

Browse files
author
Dave Kleikamp
committed
JFS: simplify types to get rid of sparse warning
jfs_metapage.c was using uints and unsigned ints inconsistently when regular ints suffice. Signed-off-by: Dave Kleikamp <[email protected]>
1 parent da8a41d commit 967c9ec

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

fs/jfs/jfs_metapage.c

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ struct meta_anchor {
8888
};
8989
#define mp_anchor(page) ((struct meta_anchor *)page_private(page))
9090

91-
static inline struct metapage *page_to_mp(struct page *page, uint offset)
91+
static inline struct metapage *page_to_mp(struct page *page, int offset)
9292
{
9393
if (!PagePrivate(page))
9494
return NULL;
@@ -153,7 +153,7 @@ static inline void dec_io(struct page *page, void (*handler) (struct page *))
153153
}
154154

155155
#else
156-
static inline struct metapage *page_to_mp(struct page *page, uint offset)
156+
static inline struct metapage *page_to_mp(struct page *page, int offset)
157157
{
158158
return PagePrivate(page) ? (struct metapage *)page_private(page) : NULL;
159159
}
@@ -249,7 +249,7 @@ static inline void drop_metapage(struct page *page, struct metapage *mp)
249249
*/
250250

251251
static sector_t metapage_get_blocks(struct inode *inode, sector_t lblock,
252-
unsigned int *len)
252+
int *len)
253253
{
254254
int rc = 0;
255255
int xflag;
@@ -352,11 +352,11 @@ static void metapage_write_end_io(struct bio *bio, int err)
352352
static int metapage_writepage(struct page *page, struct writeback_control *wbc)
353353
{
354354
struct bio *bio = NULL;
355-
unsigned int block_offset; /* block offset of mp within page */
355+
int block_offset; /* block offset of mp within page */
356356
struct inode *inode = page->mapping->host;
357-
unsigned int blocks_per_mp = JFS_SBI(inode->i_sb)->nbperpage;
358-
unsigned int len;
359-
unsigned int xlen;
357+
int blocks_per_mp = JFS_SBI(inode->i_sb)->nbperpage;
358+
int len;
359+
int xlen;
360360
struct metapage *mp;
361361
int redirty = 0;
362362
sector_t lblock;
@@ -366,7 +366,7 @@ static int metapage_writepage(struct page *page, struct writeback_control *wbc)
366366
sector_t page_start;
367367
unsigned long bio_bytes = 0;
368368
unsigned long bio_offset = 0;
369-
unsigned int offset;
369+
int offset;
370370

371371
page_start = (sector_t)page->index <<
372372
(PAGE_CACHE_SHIFT - inode->i_blkbits);
@@ -428,7 +428,7 @@ static int metapage_writepage(struct page *page, struct writeback_control *wbc)
428428
continue;
429429
}
430430
set_bit(META_io, &mp->flag);
431-
len = min(xlen, (uint) JFS_SBI(inode->i_sb)->nbperpage);
431+
len = min(xlen, (int)JFS_SBI(inode->i_sb)->nbperpage);
432432

433433
bio = bio_alloc(GFP_NOFS, 1);
434434
bio->bi_bdev = inode->i_sb->s_bdev;
@@ -480,13 +480,13 @@ static int metapage_readpage(struct file *fp, struct page *page)
480480
{
481481
struct inode *inode = page->mapping->host;
482482
struct bio *bio = NULL;
483-
unsigned int block_offset;
484-
unsigned int blocks_per_page = PAGE_CACHE_SIZE >> inode->i_blkbits;
483+
int block_offset;
484+
int blocks_per_page = PAGE_CACHE_SIZE >> inode->i_blkbits;
485485
sector_t page_start; /* address of page in fs blocks */
486486
sector_t pblock;
487-
unsigned int xlen;
487+
int xlen;
488488
unsigned int len;
489-
unsigned int offset;
489+
int offset;
490490

491491
BUG_ON(!PageLocked(page));
492492
page_start = (sector_t)page->index <<
@@ -535,7 +535,7 @@ static int metapage_releasepage(struct page *page, gfp_t gfp_mask)
535535
{
536536
struct metapage *mp;
537537
int ret = 1;
538-
unsigned int offset;
538+
int offset;
539539

540540
for (offset = 0; offset < PAGE_CACHE_SIZE; offset += PSIZE) {
541541
mp = page_to_mp(page, offset);

0 commit comments

Comments
 (0)