Skip to content

Commit 971b750

Browse files
lategoodbyeFelipe Balbi
authored andcommitted
usb: dwc2: debugfs: Don't touch RX FIFO during register dump
Dumping the registers via debugfs makes USB on Raspberry Pi completely unusable. The read of register GRXSTSP ("Receive Status Read and Pop Register") is responsible for this behaviour, because it pops the RX FIFO. So avoid this by omitting the relevant register. CC: Mian Yousaf Kaukab <[email protected]> Fixes: 563cf01 ("usb: dwc2: debugfs: add support for complete register dump") Acked-by: Minas Harutyunyan <[email protected]> Signed-off-by: Stefan Wahren <[email protected]> Signed-off-by: Felipe Balbi <[email protected]>
1 parent d5d5f07 commit 971b750

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/usb/dwc2/debugfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ static const struct debugfs_reg32 dwc2_regs[] = {
368368
dump_register(GINTSTS),
369369
dump_register(GINTMSK),
370370
dump_register(GRXSTSR),
371-
dump_register(GRXSTSP),
371+
/* Omit GRXSTSP */
372372
dump_register(GRXFSIZ),
373373
dump_register(GNPTXFSIZ),
374374
dump_register(GNPTXSTS),

0 commit comments

Comments
 (0)