HID: hid-holtekff: don't push static constants on stack for %*ph

andy-shev · Jiri Kosina · commit 9854a6f92995 · 2013-08-05T11:29:57.000+02:00
There is no need to pass constants via stack. The width may be explicitly
specified in the format.

Signed-off-by: Andy Shevchenko &lt;andriy.shevchenko@linux.intel.com&gt;
Signed-off-by: Jiri Kosina &lt;jkosina@suse.cz&gt;
diff --git a/drivers/hid/hid-holtekff.c b/drivers/hid/hid-holtekff.c
@@ -98,7 +98,7 @@ static void holtekff_send(struct holtekff_device *holtekff,
 		holtekff->field->value[i] = data[i];
 	}
 
-	dbg_hid("sending %*ph\n", 7, data);
+	dbg_hid("sending %7ph\n", data);
 
 	hid_hw_request(hid, holtekff->field->report, HID_REQ_SET_REPORT);
 }

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ static void holtekff_send(struct holtekff_device *holtekff,`
`98`	`98`	`holtekff->field->value[i] = data[i];`
`99`	`99`	`}`
`100`	`100`
`101`		`- dbg_hid("sending %*ph\n", 7, data);`
	`101`	`+ dbg_hid("sending %7ph\n", data);`
`102`	`102`
`103`	`103`	`hid_hw_request(hid, holtekff->field->report, HID_REQ_SET_REPORT);`
`104`	`104`	`}`