Skip to content

Commit 990d718

Browse files
egrumbachjmberg-intel
authored andcommitted
mac80211: ignore NullFunc frames in the duplicate detection
NullFunc packets should never be duplicate just like QoS-NullFunc packets. We saw a client that enters / exits power save with NullFunc frames (and not with QoS-NullFunc) despite the fact that the association supports HT. This specific client also re-uses a non-zero sequence number for different NullFunc frames. At some point, the client had to send a retransmission of the NullFunc frame and we dropped it, leading to a misalignment in the power save state. Fix this by never consider a NullFunc frame as duplicate, just like we do for QoS NullFunc frames. This fixes https://bugzilla.kernel.org/show_bug.cgi?id=201449 CC: <[email protected]> Signed-off-by: Emmanuel Grumbach <[email protected]> Signed-off-by: Johannes Berg <[email protected]>
1 parent 9ec1190 commit 990d718

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

net/mac80211/rx.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1403,6 +1403,7 @@ ieee80211_rx_h_check_dup(struct ieee80211_rx_data *rx)
14031403
return RX_CONTINUE;
14041404

14051405
if (ieee80211_is_ctl(hdr->frame_control) ||
1406+
ieee80211_is_nullfunc(hdr->frame_control) ||
14061407
ieee80211_is_qos_nullfunc(hdr->frame_control) ||
14071408
is_multicast_ether_addr(hdr->addr1))
14081409
return RX_CONTINUE;

0 commit comments

Comments
 (0)