Skip to content

Commit 994e0b2

Browse files
rjwysockijbarnes993
authored andcommitted
PCI hotplug: Fix unexpected driver unregister in pciehp_acpi.c
If pcie_ports_disabled is set, pcie_port_service_register() returns error code and select_detection_mode() should not attempt to unregister dummy_driver and use dummy_slots. It should return PCIEHP_DETECT_ACPI immediately instead. Reviewed-by: Kenji Kaneshige <[email protected]> Acked-by: Kenji Kaneshige <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]> Signed-off-by: Jesse Barnes <[email protected]>
1 parent e819eb8 commit 994e0b2

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/pci/hotplug/pciehp_acpi.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,8 @@ static struct pcie_port_service_driver __initdata dummy_driver = {
115115
static int __init select_detection_mode(void)
116116
{
117117
struct dummy_slot *slot, *tmp;
118-
pcie_port_service_register(&dummy_driver);
118+
if (pcie_port_service_register(&dummy_driver))
119+
return PCIEHP_DETECT_ACPI;
119120
pcie_port_service_unregister(&dummy_driver);
120121
list_for_each_entry_safe(slot, tmp, &dummy_slots, list) {
121122
list_del(&slot->list);

0 commit comments

Comments
 (0)