Skip to content

Commit 99c09c9

Browse files
lsun100jwrdegoede
authored andcommitted
platform/mellanox: mlxbf-tmfifo: Fix a warning message
This commit fixes the smatch static checker warning in function mlxbf_tmfifo_rxtx_word() which complains data not initialized at line 634 when IS_VRING_DROP() is TRUE. Signed-off-by: Liming Sun <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Hans de Goede <[email protected]> Signed-off-by: Hans de Goede <[email protected]>
1 parent 0e51cb4 commit 99c09c9

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

drivers/platform/mellanox/mlxbf-tmfifo.c

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -609,24 +609,25 @@ static void mlxbf_tmfifo_rxtx_word(struct mlxbf_tmfifo_vring *vring,
609609

610610
if (vring->cur_len + sizeof(u64) <= len) {
611611
/* The whole word. */
612-
if (!IS_VRING_DROP(vring)) {
613-
if (is_rx)
612+
if (is_rx) {
613+
if (!IS_VRING_DROP(vring))
614614
memcpy(addr + vring->cur_len, &data,
615615
sizeof(u64));
616-
else
617-
memcpy(&data, addr + vring->cur_len,
618-
sizeof(u64));
616+
} else {
617+
memcpy(&data, addr + vring->cur_len,
618+
sizeof(u64));
619619
}
620620
vring->cur_len += sizeof(u64);
621621
} else {
622622
/* Leftover bytes. */
623-
if (!IS_VRING_DROP(vring)) {
624-
if (is_rx)
623+
if (is_rx) {
624+
if (!IS_VRING_DROP(vring))
625625
memcpy(addr + vring->cur_len, &data,
626626
len - vring->cur_len);
627-
else
628-
memcpy(&data, addr + vring->cur_len,
629-
len - vring->cur_len);
627+
} else {
628+
data = 0;
629+
memcpy(&data, addr + vring->cur_len,
630+
len - vring->cur_len);
630631
}
631632
vring->cur_len = len;
632633
}

0 commit comments

Comments
 (0)