Skip to content

Commit 99d3cd2

Browse files
Inbar KarmySaeed Mahameed
authored andcommitted
net/mlx5: Fix FPGA capability location
Currently, FPGA capability is located in (mdev)->caps.hca_cur, change the location to be (mdev)->caps.fpga, since hca_cur is reserved for HCA device capabilities. Fixes: e29341f ("net/mlx5: FPGA, Add basic support for Innova") Signed-off-by: Inbar Karmy <[email protected]> Signed-off-by: Saeed Mahameed <[email protected]>
1 parent 38e8a5c commit 99d3cd2

File tree

5 files changed

+7
-8
lines changed

5 files changed

+7
-8
lines changed

drivers/net/ethernet/mellanox/mlx5/core/fpga/cmd.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,11 @@ int mlx5_fpga_access_reg(struct mlx5_core_dev *dev, u8 size, u64 addr,
7171
return 0;
7272
}
7373

74-
int mlx5_fpga_caps(struct mlx5_core_dev *dev, u32 *caps)
74+
int mlx5_fpga_caps(struct mlx5_core_dev *dev)
7575
{
7676
u32 in[MLX5_ST_SZ_DW(fpga_cap)] = {0};
7777

78-
return mlx5_core_access_reg(dev, in, sizeof(in), caps,
78+
return mlx5_core_access_reg(dev, in, sizeof(in), dev->caps.fpga,
7979
MLX5_ST_SZ_BYTES(fpga_cap),
8080
MLX5_REG_FPGA_CAP, 0, 0);
8181
}

drivers/net/ethernet/mellanox/mlx5/core/fpga/cmd.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ struct mlx5_fpga_qp_counters {
6565
u64 rx_total_drop;
6666
};
6767

68-
int mlx5_fpga_caps(struct mlx5_core_dev *dev, u32 *caps);
68+
int mlx5_fpga_caps(struct mlx5_core_dev *dev);
6969
int mlx5_fpga_query(struct mlx5_core_dev *dev, struct mlx5_fpga_query *query);
7070
int mlx5_fpga_ctrl_op(struct mlx5_core_dev *dev, u8 op);
7171
int mlx5_fpga_access_reg(struct mlx5_core_dev *dev, u8 size, u64 addr,

drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,7 @@ int mlx5_fpga_device_start(struct mlx5_core_dev *mdev)
139139
if (err)
140140
goto out;
141141

142-
err = mlx5_fpga_caps(fdev->mdev,
143-
fdev->mdev->caps.hca_cur[MLX5_CAP_FPGA]);
142+
err = mlx5_fpga_caps(fdev->mdev);
144143
if (err)
145144
goto out;
146145

include/linux/mlx5/device.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -980,7 +980,6 @@ enum mlx5_cap_type {
980980
MLX5_CAP_RESERVED,
981981
MLX5_CAP_VECTOR_CALC,
982982
MLX5_CAP_QOS,
983-
MLX5_CAP_FPGA,
984983
/* NUM OF CAP Types */
985984
MLX5_CAP_NUM
986985
};
@@ -1110,10 +1109,10 @@ enum mlx5_mcam_feature_groups {
11101109
MLX5_GET(mcam_reg, (mdev)->caps.mcam, mng_feature_cap_mask.enhanced_features.fld)
11111110

11121111
#define MLX5_CAP_FPGA(mdev, cap) \
1113-
MLX5_GET(fpga_cap, (mdev)->caps.hca_cur[MLX5_CAP_FPGA], cap)
1112+
MLX5_GET(fpga_cap, (mdev)->caps.fpga, cap)
11141113

11151114
#define MLX5_CAP64_FPGA(mdev, cap) \
1116-
MLX5_GET64(fpga_cap, (mdev)->caps.hca_cur[MLX5_CAP_FPGA], cap)
1115+
MLX5_GET64(fpga_cap, (mdev)->caps.fpga, cap)
11171116

11181117
enum {
11191118
MLX5_CMD_STAT_OK = 0x0,

include/linux/mlx5/driver.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -774,6 +774,7 @@ struct mlx5_core_dev {
774774
u32 hca_max[MLX5_CAP_NUM][MLX5_UN_SZ_DW(hca_cap_union)];
775775
u32 pcam[MLX5_ST_SZ_DW(pcam_reg)];
776776
u32 mcam[MLX5_ST_SZ_DW(mcam_reg)];
777+
u32 fpga[MLX5_ST_SZ_DW(fpga_cap)];
777778
} caps;
778779
phys_addr_t iseg_base;
779780
struct mlx5_init_seg __iomem *iseg;

0 commit comments

Comments
 (0)