Skip to content

Commit 99eb394

Browse files
kaixuxiakxanguy11
authored andcommitted
e1000e: remove the redundant value assignment in e1000_update_nvm_checksum_spt
Both of the statements are value assignment of the variable act_offset. The first value assignment is overwritten by the second and is useless. Remove it. Reported-by: Tosk Robot <[email protected]> Signed-off-by: Kaixu Xia <[email protected]> Signed-off-by: Tony Nguyen <[email protected]>
1 parent 2f7c1fd commit 99eb394

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

drivers/net/ethernet/intel/e1000e/ich8lan.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3886,13 +3886,6 @@ static s32 e1000_update_nvm_checksum_spt(struct e1000_hw *hw)
38863886
if (ret_val)
38873887
goto release;
38883888

3889-
/* And invalidate the previously valid segment by setting
3890-
* its signature word (0x13) high_byte to 0b. This can be
3891-
* done without an erase because flash erase sets all bits
3892-
* to 1's. We can write 1's to 0's without an erase
3893-
*/
3894-
act_offset = (old_bank_offset + E1000_ICH_NVM_SIG_WORD) * 2 + 1;
3895-
38963889
/* offset in words but we read dword */
38973890
act_offset = old_bank_offset + E1000_ICH_NVM_SIG_WORD - 1;
38983891
ret_val = e1000_read_flash_dword_ich8lan(hw, act_offset, &dword);

0 commit comments

Comments
 (0)