Skip to content

Commit 9a6b947

Browse files
GustavoARSilvabroonie
authored andcommitted
spi: xlp: fix error return code in xlp_spi_probe()
platform_get_irq() returns an error code, but the spi-xlp driver ignores it and always returns -EINVAL. This is not correct and, prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af Print and propagate the return value of platform_get_irq on failure. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <[email protected]> Signed-off-by: Mark Brown <[email protected]>
1 parent 5771a8c commit 9a6b947

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/spi/spi-xlp.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -393,8 +393,8 @@ static int xlp_spi_probe(struct platform_device *pdev)
393393

394394
irq = platform_get_irq(pdev, 0);
395395
if (irq < 0) {
396-
dev_err(&pdev->dev, "no IRQ resource found\n");
397-
return -EINVAL;
396+
dev_err(&pdev->dev, "no IRQ resource found: %d\n", irq);
397+
return irq;
398398
}
399399
err = devm_request_irq(&pdev->dev, irq, xlp_spi_interrupt, 0,
400400
pdev->name, xspi);

0 commit comments

Comments
 (0)