Skip to content

Commit 9a98302

Browse files
Ping-Ke ShihKalle Valo
authored andcommitted
rtlwifi: rtl8821ae: fix firmware is not ready to run
Without this patch, firmware will not run properly on rtl8821ae, and it causes bad user experience. For example, bad connection performance with low rate, higher power consumption, and so on. rtl8821ae uses two kinds of firmwares for normal and WoWlan cases, and each firmware has firmware data buffer and size individually. Original code always overwrite size of normal firmware rtlpriv->rtlhal.fwsize, and this mismatch causes firmware checksum error, then firmware can't start. In this situation, driver gives message "Firmware is not ready to run!". Fixes: fe89707 ("rtlwifi: rtl8821ae: Simplify loading of WOWLAN firmware") Signed-off-by: Ping-Ke Shih <[email protected]> Cc: Stable <[email protected]> # 4.0+ Reviewed-by: Larry Finger <[email protected]> Signed-off-by: Kalle Valo <[email protected]>
1 parent 9296331 commit 9a98302

File tree

1 file changed

+0
-1
lines changed
  • drivers/net/wireless/realtek/rtlwifi

1 file changed

+0
-1
lines changed

drivers/net/wireless/realtek/rtlwifi/core.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ static void rtl_fw_do_work(const struct firmware *firmware, void *context,
130130
firmware->size);
131131
rtlpriv->rtlhal.wowlan_fwsize = firmware->size;
132132
}
133-
rtlpriv->rtlhal.fwsize = firmware->size;
134133
release_firmware(firmware);
135134
}
136135

0 commit comments

Comments
 (0)