Skip to content

Commit 9af15c3

Browse files
Phil Sutterdavem330
authored andcommitted
device: Implement a bus agnostic dev_num_vf routine
Now that pci_bus_type has num_vf callback set, dev_num_vf can be implemented in a bus type independent way and the check for whether a PCI device is being handled in rtnetlink can be dropped. Signed-off-by: Phil Sutter <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 02e0bea commit 9af15c3

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

include/linux/device.h

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1144,6 +1144,13 @@ extern int device_online(struct device *dev);
11441144
extern void set_primary_fwnode(struct device *dev, struct fwnode_handle *fwnode);
11451145
extern void set_secondary_fwnode(struct device *dev, struct fwnode_handle *fwnode);
11461146

1147+
static inline int dev_num_vf(struct device *dev)
1148+
{
1149+
if (dev->bus && dev->bus->num_vf)
1150+
return dev->bus->num_vf(dev);
1151+
return 0;
1152+
}
1153+
11471154
/*
11481155
* Root device objects for grouping under /sys/devices
11491156
*/

include/linux/pci.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -885,7 +885,6 @@ void pcibios_setup_bridge(struct pci_bus *bus, unsigned long type);
885885
void pci_sort_breadthfirst(void);
886886
#define dev_is_pci(d) ((d)->bus == &pci_bus_type)
887887
#define dev_is_pf(d) ((dev_is_pci(d) ? to_pci_dev(d)->is_physfn : false))
888-
#define dev_num_vf(d) ((dev_is_pci(d) ? pci_num_vf(to_pci_dev(d)) : 0))
889888

890889
/* Generic PCI functions exported to card drivers */
891890

@@ -1630,7 +1629,6 @@ static inline int pci_get_new_domain_nr(void) { return -ENOSYS; }
16301629

16311630
#define dev_is_pci(d) (false)
16321631
#define dev_is_pf(d) (false)
1633-
#define dev_num_vf(d) (0)
16341632
#endif /* CONFIG_PCI */
16351633

16361634
/* Include architecture-dependent settings and functions */

net/core/rtnetlink.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -837,8 +837,7 @@ static void copy_rtnl_link_stats(struct rtnl_link_stats *a,
837837
static inline int rtnl_vfinfo_size(const struct net_device *dev,
838838
u32 ext_filter_mask)
839839
{
840-
if (dev->dev.parent && dev_is_pci(dev->dev.parent) &&
841-
(ext_filter_mask & RTEXT_FILTER_VF)) {
840+
if (dev->dev.parent && (ext_filter_mask & RTEXT_FILTER_VF)) {
842841
int num_vfs = dev_num_vf(dev->dev.parent);
843842
size_t size = nla_total_size(0);
844843
size += num_vfs *

0 commit comments

Comments
 (0)