Skip to content

Commit 9c3bafa

Browse files
Benjamin Bergsuryasaimadhu
authored andcommitted
x86/mce: Lower throttling MCE messages' priority to warning
On modern CPUs it is quite normal that the temperature limits are reached and the CPU is throttled. In fact, often the thermal design is not sufficient to cool the CPU at full load and limits can quickly be reached when a burst in load happens. This will even happen with technologies like RAPL limitting the long term power consumption of the package. Also, these limits are "softer", as Srinivas explains: "CPU temperature doesn't have to hit max(TjMax) to get these warnings. OEMs ha[ve] an ability to program a threshold where a thermal interrupt can be generated. In some systems the offset is 20C+ (Read only value). In recent systems, there is another offset on top of it which can be programmed by OS, once some agent can adjust power limits dynamically. By default this is set to low by the firmware, which I guess the prime motivation of Benjamin to submit the patch." So these messages do not usually indicate a hardware issue (e.g. insufficient cooling). Log them as warnings to avoid confusion about their severity. [ bp: Massage commit mesage. ] Signed-off-by: Benjamin Berg <[email protected]> Signed-off-by: Borislav Petkov <[email protected]> Reviewed-by: Hans de Goede <[email protected]> Tested-by: Christian Kellner <[email protected]> Cc: "H. Peter Anvin" <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: linux-edac <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Srinivas Pandruvada <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Tony Luck <[email protected]> Cc: x86-ml <[email protected]> Link: https://lkml.kernel.org/r/[email protected]
1 parent 70f0c23 commit 9c3bafa

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/x86/kernel/cpu/mce/therm_throt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ static void therm_throt_process(bool new_event, int event, int level)
188188
/* if we just entered the thermal event */
189189
if (new_event) {
190190
if (event == THERMAL_THROTTLING_EVENT)
191-
pr_crit("CPU%d: %s temperature above threshold, cpu clock throttled (total events = %lu)\n",
191+
pr_warn("CPU%d: %s temperature above threshold, cpu clock throttled (total events = %lu)\n",
192192
this_cpu,
193193
level == CORE_LEVEL ? "Core" : "Package",
194194
state->count);

0 commit comments

Comments
 (0)