Skip to content

Commit 9cf5c09

Browse files
committed
Merge tag 'asm-generic-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic
Pull asm-generic cleanups from Arnd Bergmann: "The asm-generic changes for 4.4 are mostly a series from Christoph Hellwig to clean up various abuses of headers in there. The patch to rename the io-64-nonatomic-*.h headers caused some conflicts with new users, so I added a workaround that we can remove in the next merge window. The only other patch is a warning fix from Marek Vasut" * tag 'asm-generic-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic: asm-generic: temporarily add back asm-generic/io-64-nonatomic*.h asm-generic: cmpxchg: avoid warnings from macro-ized cmpxchg() implementations gpio-mxc: stop including <asm-generic/bug> n_tracesink: stop including <asm-generic/bug> n_tracerouter: stop including <asm-generic/bug> mlx5: stop including <asm-generic/kmap_types.h> hifn_795x: stop including <asm-generic/kmap_types.h> drbd: stop including <asm-generic/kmap_types.h> move count_zeroes.h out of asm-generic move io-64-nonatomic*.h out of asm-generic
2 parents 22402cd + 4008cb3 commit 9cf5c09

File tree

32 files changed

+103
-100
lines changed

32 files changed

+103
-100
lines changed

drivers/acpi/nfit.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
* For readq() and writeq() on 32-bit builds, the hi-lo, lo-hi order is
2828
* irrelevant.
2929
*/
30-
#include <asm-generic/io-64-nonatomic-hi-lo.h>
30+
#include <linux/io-64-nonatomic-hi-lo.h>
3131

3232
static bool force_enable_dimms;
3333
module_param(force_enable_dimms, bool, S_IRUGO|S_IWUSR);

drivers/acpi/osl.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343

4444
#include <asm/io.h>
4545
#include <asm/uaccess.h>
46-
#include <asm-generic/io-64-nonatomic-lo-hi.h>
46+
#include <linux/io-64-nonatomic-lo-hi.h>
4747

4848
#include "internal.h"
4949

drivers/block/drbd/drbd_bitmap.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
#include <linux/string.h>
3030
#include <linux/drbd.h>
3131
#include <linux/slab.h>
32-
#include <asm/kmap_types.h>
32+
#include <linux/highmem.h>
3333

3434
#include "drbd_int.h"
3535

drivers/crypto/hifn_795x.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@
3636
#include <crypto/algapi.h>
3737
#include <crypto/des.h>
3838

39-
#include <asm/kmap_types.h>
40-
4139
//#define HIFN_DEBUG
4240

4341
#ifdef HIFN_DEBUG

drivers/edac/i3200_edac.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
#include <linux/io.h>
1616
#include "edac_core.h"
1717

18-
#include <asm-generic/io-64-nonatomic-lo-hi.h>
18+
#include <linux/io-64-nonatomic-lo-hi.h>
1919

2020
#define I3200_REVISION "1.1"
2121

drivers/edac/ie31200_edac.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
#include <linux/pci_ids.h>
4040
#include <linux/edac.h>
4141

42-
#include <asm-generic/io-64-nonatomic-lo-hi.h>
42+
#include <linux/io-64-nonatomic-lo-hi.h>
4343
#include "edac_core.h"
4444

4545
#define IE31200_REVISION "1.0"

drivers/edac/x38_edac.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
#include <linux/pci_ids.h>
1616
#include <linux/edac.h>
1717

18-
#include <asm-generic/io-64-nonatomic-lo-hi.h>
18+
#include <linux/io-64-nonatomic-lo-hi.h>
1919
#include "edac_core.h"
2020

2121
#define X38_REVISION "1.1"

drivers/gpio/gpio-mxc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
#include <linux/of.h>
3434
#include <linux/of_device.h>
3535
#include <linux/module.h>
36-
#include <asm-generic/bug.h>
36+
#include <linux/bug.h>
3737

3838
enum mxc_gpio_hwtype {
3939
IMX1_GPIO, /* runs on i.mx1 */

drivers/i2c/busses/i2c-ismt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
#include <linux/acpi.h>
6868
#include <linux/interrupt.h>
6969

70-
#include <asm-generic/io-64-nonatomic-lo-hi.h>
70+
#include <linux/io-64-nonatomic-lo-hi.h>
7171

7272
/* PCI Address Constants */
7373
#define SMBBAR 0

drivers/infiniband/hw/mlx5/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
* SOFTWARE.
3131
*/
3232

33-
#include <asm-generic/kmap_types.h>
33+
#include <linux/highmem.h>
3434
#include <linux/module.h>
3535
#include <linux/init.h>
3636
#include <linux/errno.h>

drivers/mfd/intel-lpss.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@
2525
#include <linux/pm_qos.h>
2626
#include <linux/pm_runtime.h>
2727
#include <linux/seq_file.h>
28-
29-
#include <asm-generic/io-64-nonatomic-lo-hi.h>
28+
#include <linux/io-64-nonatomic-lo-hi.h>
3029

3130
#include "intel-lpss.h"
3231

drivers/net/ethernet/intel/i40e/i40e_osdep.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
#include <linux/highuid.h>
3636

3737
/* get readq/writeq support for 32 bit kernels, use the low-first version */
38-
#include <asm-generic/io-64-nonatomic-lo-hi.h>
38+
#include <linux/io-64-nonatomic-lo-hi.h>
3939

4040
/* File to be the magic between shared code and
4141
* actual OS primitives

drivers/net/ethernet/intel/i40evf/i40e_osdep.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
#include <linux/pci.h>
3535

3636
/* get readq/writeq support for 32 bit kernels, use the low-first version */
37-
#include <asm-generic/io-64-nonatomic-lo-hi.h>
37+
#include <linux/io-64-nonatomic-lo-hi.h>
3838

3939
/* File to be the magic between shared code and
4040
* actual OS primitives

drivers/net/ethernet/mellanox/mlx5/core/cmd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
* SOFTWARE.
3131
*/
3232

33-
#include <asm-generic/kmap_types.h>
33+
#include <linux/highmem.h>
3434
#include <linux/module.h>
3535
#include <linux/errno.h>
3636
#include <linux/pci.h>

drivers/net/ethernet/mellanox/mlx5/core/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
* SOFTWARE.
3131
*/
3232

33-
#include <asm-generic/kmap_types.h>
33+
#include <linux/highmem.h>
3434
#include <linux/module.h>
3535
#include <linux/init.h>
3636
#include <linux/errno.h>

drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
* SOFTWARE.
3131
*/
3232

33-
#include <asm-generic/kmap_types.h>
33+
#include <linux/highmem.h>
3434
#include <linux/kernel.h>
3535
#include <linux/module.h>
3636
#include <linux/mlx5/driver.h>

drivers/net/ethernet/rocker/rocker.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
#include <net/ip_fib.h>
3737
#include <net/netevent.h>
3838
#include <net/arp.h>
39-
#include <asm-generic/io-64-nonatomic-lo-hi.h>
39+
#include <linux/io-64-nonatomic-lo-hi.h>
4040
#include <generated/utsrelease.h>
4141

4242
#include "rocker.h"

drivers/nvme/host/pci.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
#include <linux/types.h>
4242
#include <linux/pr.h>
4343
#include <scsi/sg.h>
44-
#include <asm-generic/io-64-nonatomic-lo-hi.h>
44+
#include <linux/io-64-nonatomic-lo-hi.h>
4545
#include <asm/unaligned.h>
4646

4747
#include <uapi/linux/nvme_ioctl.h>

drivers/platform/x86/ibm_rtl.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
#include <linux/mutex.h>
3434
#include <asm/bios_ebda.h>
3535

36-
#include <asm-generic/io-64-nonatomic-lo-hi.h>
36+
#include <linux/io-64-nonatomic-lo-hi.h>
3737

3838
static bool force;
3939
module_param(force, bool, 0);

drivers/platform/x86/intel_ips.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
#include <asm/processor.h>
7979
#include "intel_ips.h"
8080

81-
#include <asm-generic/io-64-nonatomic-lo-hi.h>
81+
#include <linux/io-64-nonatomic-lo-hi.h>
8282

8383
#define PCI_DEVICE_ID_INTEL_THERMAL_SENSOR 0x3b32
8484

drivers/scsi/qla4xxx/ql4_nx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
#include "ql4_glbl.h"
1313
#include "ql4_inline.h"
1414

15-
#include <asm-generic/io-64-nonatomic-lo-hi.h>
15+
#include <linux/io-64-nonatomic-lo-hi.h>
1616

1717
#define TIMEOUT_100_MS 100
1818
#define MASK(n) DMA_BIT_MASK(n)

drivers/tty/n_tracerouter.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
#include <linux/string.h>
3535
#include <linux/mutex.h>
3636
#include <linux/slab.h>
37-
#include <asm-generic/bug.h>
37+
#include <linux/bug.h>
3838
#include "n_tracesink.h"
3939

4040
/*

drivers/tty/n_tracesink.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
#include <linux/tty_ldisc.h>
3535
#include <linux/errno.h>
3636
#include <linux/string.h>
37-
#include <asm-generic/bug.h>
37+
#include <linux/bug.h>
3838
#include "n_tracesink.h"
3939

4040
/*

drivers/usb/host/xhci.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@
2828
#include <linux/timer.h>
2929
#include <linux/kernel.h>
3030
#include <linux/usb/hcd.h>
31-
32-
#include <asm-generic/io-64-nonatomic-lo-hi.h>
31+
#include <linux/io-64-nonatomic-lo-hi.h>
3332

3433
/* Code sharing between pci-quirks and xhci hcd */
3534
#include "xhci-ext-caps.h"

include/asm-generic/cmpxchg.h

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,10 @@ unsigned long __xchg(unsigned long x, volatile void *ptr, int size)
7979
}
8080
}
8181

82-
#define xchg(ptr, x) \
83-
((__typeof__(*(ptr))) __xchg((unsigned long)(x), (ptr), sizeof(*(ptr))))
82+
#define xchg(ptr, x) ({ \
83+
((__typeof__(*(ptr))) \
84+
__xchg((unsigned long)(x), (ptr), sizeof(*(ptr)))); \
85+
})
8486

8587
#endif /* xchg */
8688

@@ -90,9 +92,10 @@ unsigned long __xchg(unsigned long x, volatile void *ptr, int size)
9092
#include <asm-generic/cmpxchg-local.h>
9193

9294
#ifndef cmpxchg_local
93-
#define cmpxchg_local(ptr, o, n) \
95+
#define cmpxchg_local(ptr, o, n) ({ \
9496
((__typeof__(*(ptr)))__cmpxchg_local_generic((ptr), (unsigned long)(o),\
95-
(unsigned long)(n), sizeof(*(ptr))))
97+
(unsigned long)(n), sizeof(*(ptr)))); \
98+
})
9699
#endif
97100

98101
#ifndef cmpxchg64_local
Lines changed: 2 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,2 @@
1-
#ifndef _ASM_IO_64_NONATOMIC_HI_LO_H_
2-
#define _ASM_IO_64_NONATOMIC_HI_LO_H_
3-
4-
#include <linux/io.h>
5-
#include <asm-generic/int-ll64.h>
6-
7-
static inline __u64 hi_lo_readq(const volatile void __iomem *addr)
8-
{
9-
const volatile u32 __iomem *p = addr;
10-
u32 low, high;
11-
12-
high = readl(p + 1);
13-
low = readl(p);
14-
15-
return low + ((u64)high << 32);
16-
}
17-
18-
static inline void hi_lo_writeq(__u64 val, volatile void __iomem *addr)
19-
{
20-
writel(val >> 32, addr + 4);
21-
writel(val, addr);
22-
}
23-
24-
#ifndef readq
25-
#define readq hi_lo_readq
26-
#endif
27-
28-
#ifndef writeq
29-
#define writeq hi_lo_writeq
30-
#endif
31-
32-
#endif /* _ASM_IO_64_NONATOMIC_HI_LO_H_ */
1+
/* XXX: delete asm-generic/io-64-nonatomic-hi-lo.h after converting new users */
2+
#include <linux/io-64-nonatomic-hi-lo.h>
Lines changed: 2 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,2 @@
1-
#ifndef _ASM_IO_64_NONATOMIC_LO_HI_H_
2-
#define _ASM_IO_64_NONATOMIC_LO_HI_H_
3-
4-
#include <linux/io.h>
5-
#include <asm-generic/int-ll64.h>
6-
7-
static inline __u64 lo_hi_readq(const volatile void __iomem *addr)
8-
{
9-
const volatile u32 __iomem *p = addr;
10-
u32 low, high;
11-
12-
low = readl(p);
13-
high = readl(p + 1);
14-
15-
return low + ((u64)high << 32);
16-
}
17-
18-
static inline void lo_hi_writeq(__u64 val, volatile void __iomem *addr)
19-
{
20-
writel(val, addr);
21-
writel(val >> 32, addr + 4);
22-
}
23-
24-
#ifndef readq
25-
#define readq lo_hi_readq
26-
#endif
27-
28-
#ifndef writeq
29-
#define writeq lo_hi_writeq
30-
#endif
31-
32-
#endif /* _ASM_IO_64_NONATOMIC_LO_HI_H_ */
1+
/* XXX: delete asm-generic/io-64-nonatomic-lo-hi.h after converting new users */
2+
#include <linux/io-64-nonatomic-lo-hi.h>

include/asm-generic/bitops/count_zeros.h renamed to include/linux/count_zeros.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
* 2 of the Licence, or (at your option) any later version.
1010
*/
1111

12-
#ifndef _ASM_GENERIC_BITOPS_COUNT_ZEROS_H_
13-
#define _ASM_GENERIC_BITOPS_COUNT_ZEROS_H_
12+
#ifndef _LINUX_BITOPS_COUNT_ZEROS_H_
13+
#define _LINUX_BITOPS_COUNT_ZEROS_H_
1414

1515
#include <asm/bitops.h>
1616

@@ -54,4 +54,4 @@ static inline int count_trailing_zeros(unsigned long x)
5454
return (x != 0) ? __ffs(x) : COUNT_TRAILING_ZEROS_0;
5555
}
5656

57-
#endif /* _ASM_GENERIC_BITOPS_COUNT_ZEROS_H_ */
57+
#endif /* _LINUX_BITOPS_COUNT_ZEROS_H_ */

include/linux/io-64-nonatomic-hi-lo.h

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
#ifndef _LINUX_IO_64_NONATOMIC_HI_LO_H_
2+
#define _LINUX_IO_64_NONATOMIC_HI_LO_H_
3+
4+
#include <linux/io.h>
5+
#include <asm-generic/int-ll64.h>
6+
7+
static inline __u64 hi_lo_readq(const volatile void __iomem *addr)
8+
{
9+
const volatile u32 __iomem *p = addr;
10+
u32 low, high;
11+
12+
high = readl(p + 1);
13+
low = readl(p);
14+
15+
return low + ((u64)high << 32);
16+
}
17+
18+
static inline void hi_lo_writeq(__u64 val, volatile void __iomem *addr)
19+
{
20+
writel(val >> 32, addr + 4);
21+
writel(val, addr);
22+
}
23+
24+
#ifndef readq
25+
#define readq hi_lo_readq
26+
#endif
27+
28+
#ifndef writeq
29+
#define writeq hi_lo_writeq
30+
#endif
31+
32+
#endif /* _LINUX_IO_64_NONATOMIC_HI_LO_H_ */

include/linux/io-64-nonatomic-lo-hi.h

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
#ifndef _LINUX_IO_64_NONATOMIC_LO_HI_H_
2+
#define _LINUX_IO_64_NONATOMIC_LO_HI_H_
3+
4+
#include <linux/io.h>
5+
#include <asm-generic/int-ll64.h>
6+
7+
static inline __u64 lo_hi_readq(const volatile void __iomem *addr)
8+
{
9+
const volatile u32 __iomem *p = addr;
10+
u32 low, high;
11+
12+
low = readl(p);
13+
high = readl(p + 1);
14+
15+
return low + ((u64)high << 32);
16+
}
17+
18+
static inline void lo_hi_writeq(__u64 val, volatile void __iomem *addr)
19+
{
20+
writel(val, addr);
21+
writel(val >> 32, addr + 4);
22+
}
23+
24+
#ifndef readq
25+
#define readq lo_hi_readq
26+
#endif
27+
28+
#ifndef writeq
29+
#define writeq lo_hi_writeq
30+
#endif
31+
32+
#endif /* _LINUX_IO_64_NONATOMIC_LO_HI_H_ */

0 commit comments

Comments
 (0)