Skip to content

Commit 9d55b99

Browse files
KAGA-KOKOIngo Molnar
authored andcommitted
x86: replace LOCK_PREFIX in futex.h
The exception fixup for the futex macros __futex_atomic_op1/2 and futex_atomic_cmpxchg_inatomic() is missing an entry when the lock prefix is replaced by a NOP via SMP alternatives. Chuck Ebert tracked this down from the information provided in: https://bugzilla.redhat.com/show_bug.cgi?id=429412 A possible solution would be to add another fixup after the LOCK_PREFIX, so both the LOCK and NOP case have their own entry in the exception table, but it's not really worth the trouble. Simply replace LOCK_PREFIX with lock and keep those untouched by SMP alternatives. Signed-off-by: Thomas Gleixner <[email protected]> Signed-off-by: Ingo Molnar <[email protected]>
1 parent 5df7fa1 commit 9d55b99

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

include/asm-x86/futex.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"1: movl %2, %0\n \
3131
movl %0, %3\n" \
3232
insn "\n" \
33-
"2: " LOCK_PREFIX "cmpxchgl %3, %2\n \
33+
"2: lock; cmpxchgl %3, %2\n \
3434
jnz 1b\n \
3535
3: .section .fixup,\"ax\"\n \
3636
4: mov %5, %1\n \
@@ -72,7 +72,7 @@ futex_atomic_op_inuser(int encoded_op, int __user *uaddr)
7272
__futex_atomic_op1("xchgl %0, %2", ret, oldval, uaddr, oparg);
7373
break;
7474
case FUTEX_OP_ADD:
75-
__futex_atomic_op1(LOCK_PREFIX "xaddl %0, %2", ret, oldval,
75+
__futex_atomic_op1("lock; xaddl %0, %2", ret, oldval,
7676
uaddr, oparg);
7777
break;
7878
case FUTEX_OP_OR:
@@ -111,8 +111,8 @@ futex_atomic_cmpxchg_inatomic(int __user *uaddr, int oldval, int newval)
111111
return -EFAULT;
112112

113113
__asm__ __volatile__(
114-
"1: " LOCK_PREFIX "cmpxchgl %3, %1 \n"
115114

115+
"1: lock; cmpxchgl %3, %1 \n"
116116
"2: .section .fixup, \"ax\" \n"
117117
"3: mov %2, %0 \n"
118118
" jmp 2b \n"

0 commit comments

Comments
 (0)