Skip to content

Commit 9d9ad4b

Browse files
ppwaskietorvalds
authored andcommitted
x86: Fix 32-bit MSI-X allocation leakage
This bug was introduced in the 2.6.24 i386/x86_64 tree merge, where MSI-X vector allocation will eventually fail. The cause is the new bit array tracking used vectors is not getting cleared properly on IRQ destruction on the 32-bit APIC code. This can be seen easily using the ixgbe 10 GbE driver on multi-core systems by simply loading and unloading the driver a few times. Depending on the number of available vectors on the host system, the MSI-X allocation will eventually fail, and the driver will only be able to use legacy interrupts. I am generating the same patch for both stable trees for 2.6.24 and 2.6.25. Signed-off-by: Peter P Waskiewicz Jr <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent a04140e commit 9d9ad4b

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

arch/x86/kernel/io_apic_32.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2444,6 +2444,7 @@ void destroy_irq(unsigned int irq)
24442444
dynamic_irq_cleanup(irq);
24452445

24462446
spin_lock_irqsave(&vector_lock, flags);
2447+
clear_bit(irq_vector[irq], used_vectors);
24472448
irq_vector[irq] = 0;
24482449
spin_unlock_irqrestore(&vector_lock, flags);
24492450
}

0 commit comments

Comments
 (0)