Skip to content

Commit 9d9b010

Browse files
Ben DooksMarc Zyngier
authored andcommitted
irqchip/mmp: Declare init functions in common header file
The functions icu_init_irq and mmp2_init_icu are exported from this code, so declare them in the header file to avoid the following sparse warnings: drivers/irqchip/irq-mmp.c:248:13: warning: symbol 'icu_init_irq' was not declared. Should it be static? drivers/irqchip/irq-mmp.c:271:13: warning: symbol 'mmp2_init_icu' was not declared. Should it be static? Signed-off-by: Ben Dooks <[email protected]> [maz: fixup commit message] Signed-off-by: Marc Zyngier <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 71349cc commit 9d9b010

File tree

4 files changed

+6
-3
lines changed

4 files changed

+6
-3
lines changed

arch/arm/mach-mmp/mmp2.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@
55
#include <linux/platform_data/pxa_sdhci.h>
66

77
extern void mmp2_timer_init(void);
8-
extern void __init mmp2_init_icu(void);
98
extern void __init mmp2_init_irq(void);
109
extern void mmp2_clear_pmic_int(void);
1110

1211
#include <linux/i2c.h>
1312
#include <linux/platform_data/i2c-pxa.h>
1413
#include <linux/platform_data/dma-mmp_tdma.h>
14+
#include <linux/irqchip/mmp.h>
1515

1616
#include "devices.h"
1717

arch/arm/mach-mmp/pxa168.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
#include <linux/reboot.h>
66

77
extern void pxa168_timer_init(void);
8-
extern void __init icu_init_irq(void);
98
extern void __init pxa168_init_irq(void);
109
extern void pxa168_restart(enum reboot_mode, const char *);
1110
extern void pxa168_clear_keypad_wakeup(void);
@@ -18,6 +17,7 @@ extern void pxa168_clear_keypad_wakeup(void);
1817
#include <linux/pxa168_eth.h>
1918
#include <linux/platform_data/mv_usb.h>
2019
#include <linux/soc/mmp/cputype.h>
20+
#include <linux/irqchip/mmp.h>
2121

2222
#include "devices.h"
2323

arch/arm/mach-mmp/pxa910.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@
33
#define __ASM_MACH_PXA910_H
44

55
extern void pxa910_timer_init(void);
6-
extern void __init icu_init_irq(void);
76
extern void __init pxa910_init_irq(void);
87

98
#include <linux/i2c.h>
109
#include <linux/platform_data/i2c-pxa.h>
1110
#include <linux/platform_data/mtd-nand-pxa3xx.h>
1211
#include <video/mmp_disp.h>
12+
#include <linux/irqchip/mmp.h>
1313

1414
#include "devices.h"
1515

include/linux/irqchip/mmp.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,7 @@
44

55
extern struct irq_chip icu_irq_chip;
66

7+
extern void icu_init_irq(void);
8+
extern void mmp2_init_icu(void);
9+
710
#endif /* __IRQCHIP_MMP_H */

0 commit comments

Comments
 (0)