Skip to content

Commit 9dedfd6

Browse files
Wei Lin GuayLinuxMinion
authored andcommitted
Revert "net/rds: use different workqueue for base_conn"
This reverts commit ad7312b ("net/rds: use different workqueue for base_conn"). The RDS path record caching will be replaced by ibacm. Thus, all the TOS connections do not rely on its base connection to perform SA query. As a result, RDS does not need a separate "priority" workqueue for the base connection. Orabug: 26497333 Signed-off-by: Wei Lin Guay <[email protected]> Reviewed-by: Håkon Bugge <[email protected]> Reviewed-by: Avinash Repaka <[email protected]> Reviewed-by: Ajaykumar Hotchandani <[email protected]>
1 parent 7577ff1 commit 9dedfd6

File tree

4 files changed

+2
-11
lines changed

4 files changed

+2
-11
lines changed

net/rds/connection.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,7 @@ static struct rds_connection *__rds_conn_create(struct net *net,
251251
}
252252

253253
conn->c_trans = trans;
254+
254255
init_waitqueue_head(&conn->c_hs_waitq);
255256
for (i = 0; i < npaths; i++) {
256257
struct rds_conn_path *cp;
@@ -262,7 +263,7 @@ static struct rds_connection *__rds_conn_create(struct net *net,
262263
if (conn->c_loopback)
263264
cp->cp_wq = rds_local_wq;
264265
else
265-
cp->cp_wq = tos ? rds_wq : rds_tos_wq;
266+
cp->cp_wq = rds_wq;
266267
}
267268
ret = trans->conn_alloc(conn, gfp);
268269
if (ret) {

net/rds/ib.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2100,8 +2100,6 @@ static void rds_ib_unregister_client(void)
21002100
ib_unregister_client(&rds_ib_client);
21012101
/* wait for rds_ib_dev_free() to complete */
21022102
flush_workqueue(rds_ip_wq);
2103-
flush_workqueue(rds_wq);
2104-
flush_workqueue(rds_tos_wq);
21052103
flush_workqueue(rds_local_wq);
21062104
}
21072105

net/rds/rds.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1141,7 +1141,6 @@ extern unsigned int rds_sysctl_shutdown_trace_end_time;
11411141
int rds_threads_init(void);
11421142
void rds_threads_exit(void);
11431143
extern struct workqueue_struct *rds_wq;
1144-
extern struct workqueue_struct *rds_tos_wq;
11451144
extern struct workqueue_struct *rds_local_wq;
11461145
void rds_queue_reconnect(struct rds_conn_path *cp, int reason);
11471146
void rds_connect_worker(struct work_struct *);

net/rds/threads.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,6 @@ MODULE_PARM_DESC(rds_conn_hb_timeout, " Connection heartbeat timeout");
7474
*/
7575
struct workqueue_struct *rds_wq;
7676
EXPORT_SYMBOL_GPL(rds_wq);
77-
struct workqueue_struct *rds_tos_wq;
78-
EXPORT_SYMBOL_GPL(rds_tos_wq);
7977
struct workqueue_struct *rds_local_wq;
8078
EXPORT_SYMBOL_GPL(rds_local_wq);
8179

@@ -365,7 +363,6 @@ void rds_shutdown_worker(struct work_struct *work)
365363
void rds_threads_exit(void)
366364
{
367365
destroy_workqueue(rds_wq);
368-
destroy_workqueue(rds_tos_wq);
369366
destroy_workqueue(rds_local_wq);
370367
}
371368

@@ -375,10 +372,6 @@ int rds_threads_init(void)
375372
if (!rds_wq)
376373
return -ENOMEM;
377374

378-
rds_tos_wq = create_singlethread_workqueue("krdsd_tos");
379-
if (!rds_wq)
380-
return -ENOMEM;
381-
382375
rds_local_wq = create_singlethread_workqueue("krdsd_local");
383376
if (!rds_local_wq)
384377
return -ENOMEM;

0 commit comments

Comments
 (0)