Skip to content

Commit 9fb3cd8

Browse files
sswenJames Bottomley
authored andcommitted
[SCSI] zfcp: fix erp list usage without using locks
The zfcp_erp_thread was using the nolock version of the dbf function. This resulted in a list access while other tasks could modifying the list. The symptom was an erp thread running at 100% CPU and never returning from the dbf function. Signed-off-by: Swen Schillig <[email protected]> Signed-off-by: Christof Schmitt <[email protected]> Signed-off-by: James Bottomley <[email protected]>
1 parent e4e9ba5 commit 9fb3cd8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/s390/scsi/zfcp_erp.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1395,9 +1395,9 @@ static int zfcp_erp_thread(void *data)
13951395
zfcp_erp_wakeup(adapter);
13961396
}
13971397

1398-
zfcp_rec_dbf_event_thread(4, adapter);
1398+
zfcp_rec_dbf_event_thread_lock(4, adapter);
13991399
down_interruptible(&adapter->erp_ready_sem);
1400-
zfcp_rec_dbf_event_thread(5, adapter);
1400+
zfcp_rec_dbf_event_thread_lock(5, adapter);
14011401
}
14021402

14031403
atomic_clear_mask(ZFCP_STATUS_ADAPTER_ERP_THREAD_UP, &adapter->status);

0 commit comments

Comments
 (0)