Skip to content

Commit 9fd64e8

Browse files
committed
Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
Pull timer fix from Ingo Molnar: "Make posix clock ID usage Spectre-safe" * 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: posix-timers: Protect posix clock array access against speculation
2 parents bf45bae + 19b558d commit 9fd64e8

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

kernel/time/posix-timers.c

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
#include <linux/export.h>
5151
#include <linux/hashtable.h>
5252
#include <linux/compat.h>
53+
#include <linux/nospec.h>
5354

5455
#include "timekeeping.h"
5556
#include "posix-timers.h"
@@ -1346,11 +1347,15 @@ static const struct k_clock * const posix_clocks[] = {
13461347

13471348
static const struct k_clock *clockid_to_kclock(const clockid_t id)
13481349
{
1349-
if (id < 0)
1350+
clockid_t idx = id;
1351+
1352+
if (id < 0) {
13501353
return (id & CLOCKFD_MASK) == CLOCKFD ?
13511354
&clock_posix_dynamic : &clock_posix_cpu;
1355+
}
13521356

1353-
if (id >= ARRAY_SIZE(posix_clocks) || !posix_clocks[id])
1357+
if (id >= ARRAY_SIZE(posix_clocks))
13541358
return NULL;
1355-
return posix_clocks[id];
1359+
1360+
return posix_clocks[array_index_nospec(idx, ARRAY_SIZE(posix_clocks))];
13561361
}

0 commit comments

Comments
 (0)