Skip to content

Commit a069215

Browse files
ffainellidavem330
authored andcommitted
net: fec: Fix unbalanced PM runtime calls
When unbinding/removing the driver, we will run into the following warnings: [ 259.655198] fec 400d1000.ethernet: 400d1000.ethernet supply phy not found, using dummy regulator [ 259.665065] fec 400d1000.ethernet: Unbalanced pm_runtime_enable! [ 259.672770] fec 400d1000.ethernet (unnamed net_device) (uninitialized): Invalid MAC address: 00:00:00:00:00:00 [ 259.683062] fec 400d1000.ethernet (unnamed net_device) (uninitialized): Using random MAC address: f2:3e:93:b7:29:c1 [ 259.696239] libphy: fec_enet_mii_bus: probed Avoid these warnings by balancing the runtime PM calls during fec_drv_remove(). Signed-off-by: Florian Fainelli <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 034f405 commit a069215

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/net/ethernet/freescale/fec_main.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3600,6 +3600,8 @@ fec_drv_remove(struct platform_device *pdev)
36003600
fec_enet_mii_remove(fep);
36013601
if (fep->reg_phy)
36023602
regulator_disable(fep->reg_phy);
3603+
pm_runtime_put(&pdev->dev);
3604+
pm_runtime_disable(&pdev->dev);
36033605
if (of_phy_is_fixed_link(np))
36043606
of_phy_deregister_fixed_link(np);
36053607
of_node_put(fep->phy_node);

0 commit comments

Comments
 (0)