Skip to content

Commit a1179ac

Browse files
author
Al Viro
committed
microblaze: fix livelock in uaccess
microblaze equivalent of 26178ec "x86: mm: consolidate VM_FAULT_RETRY handling" If e.g. get_user() triggers a page fault and a fatal signal is caught, we might end up with handle_mm_fault() returning VM_FAULT_RETRY and not doing anything to page tables. In such case we must *not* return to the faulting insn - that would repeat the entire thing without making any progress; what we need instead is to treat that as failed (user) memory access. Signed-off-by: Al Viro <[email protected]>
1 parent d088af1 commit a1179ac

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

arch/microblaze/mm/fault.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,8 +219,11 @@ void do_page_fault(struct pt_regs *regs, unsigned long address,
219219
*/
220220
fault = handle_mm_fault(vma, address, flags, regs);
221221

222-
if (fault_signal_pending(fault, regs))
222+
if (fault_signal_pending(fault, regs)) {
223+
if (!user_mode(regs))
224+
bad_page_fault(regs, address, SIGBUS);
223225
return;
226+
}
224227

225228
/* The fault is fully completed (including releasing mmap lock) */
226229
if (fault & VM_FAULT_COMPLETED)

0 commit comments

Comments
 (0)