Skip to content

Commit a129b41

Browse files
dolcinikuba-moo
authored andcommitted
Revert "net: phy: dp83867: perform soft reset and retain established link"
This reverts commit da9ef50. This fixes a regression in which the link would come up, but no communication was possible. The reverted commit was also removing a comment about DP83867_PHYCR_FORCE_LINK_GOOD, this is not added back in this commits since it seems that this is unrelated to the original code change. Closes: https://lore.kernel.org/all/[email protected]/ Fixes: da9ef50 ("net: phy: dp83867: perform soft reset and retain established link") Signed-off-by: Francesco Dolcini <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Reviewed-by: Praneeth Bajjuri <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 408c090 commit a129b41

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/phy/dp83867.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -936,7 +936,7 @@ static int dp83867_phy_reset(struct phy_device *phydev)
936936
{
937937
int err;
938938

939-
err = phy_write(phydev, DP83867_CTRL, DP83867_SW_RESTART);
939+
err = phy_write(phydev, DP83867_CTRL, DP83867_SW_RESET);
940940
if (err < 0)
941941
return err;
942942

0 commit comments

Comments
 (0)