Skip to content

Commit a12f809

Browse files
musamaanjumKalle Valo
authored andcommitted
rtw88: check for validity before using a pointer
ieee80211_probereq_get() can return NULL. Pointer skb should be checked for validty before use. If it is not valid, list of skbs needs to be freed. Fixes: 10d162b ("rtw88: 8822c: add ieee80211_ops::hw_scan") Signed-off-by: Muhammad Usama Anjum <[email protected]> Signed-off-by: Ping-Ke Shih <[email protected]> Signed-off-by: Kalle Valo <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 8ec10f1 commit a12f809

File tree

1 file changed

+8
-0
lines changed
  • drivers/net/wireless/realtek/rtw88

1 file changed

+8
-0
lines changed

drivers/net/wireless/realtek/rtw88/fw.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1866,11 +1866,19 @@ static int rtw_hw_scan_update_probe_req(struct rtw_dev *rtwdev,
18661866
req->ssids[i].ssid,
18671867
req->ssids[i].ssid_len,
18681868
req->ie_len);
1869+
if (!skb)
1870+
goto out;
18691871
rtw_append_probe_req_ie(rtwdev, skb, &list, rtwvif);
18701872
kfree_skb(skb);
18711873
}
18721874

18731875
return _rtw_hw_scan_update_probe_req(rtwdev, num, &list);
1876+
1877+
out:
1878+
skb_queue_walk(&list, skb)
1879+
kfree_skb(skb);
1880+
1881+
return -ENOMEM;
18741882
}
18751883

18761884
static int rtw_add_chan_info(struct rtw_dev *rtwdev, struct rtw_chan_info *info,

0 commit comments

Comments
 (0)