Skip to content

Commit a184d4e

Browse files
committed
Merge branch 'for-linus' into for-next
Need to merge the fixes regarding EPSS. Conflicts: sound/pci/hda/hda_codec.c
2 parents 5d908ab + c36b5b0 commit a184d4e

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

sound/isa/als100.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ static int __devinit snd_card_als100_probe(int dev,
233233
irq[dev], dma8[dev], dma16[dev]);
234234
}
235235

236-
if ((error = snd_sb16dsp_pcm(chip, 0, NULL)) < 0) {
236+
if ((error = snd_sb16dsp_pcm(chip, 0, &chip->pcm)) < 0) {
237237
snd_card_free(card);
238238
return error;
239239
}

sound/pci/hda/hda_codec.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1327,6 +1327,9 @@ int /*__devinit*/ snd_hda_codec_new(struct hda_bus *bus,
13271327
if (!codec->d3_stop_clk)
13281328
bus->power_keep_link_on = 1;
13291329
#endif
1330+
codec->epss = snd_hda_codec_get_supported_ps(codec,
1331+
codec->afg ? codec->afg : codec->mfg,
1332+
AC_PWRST_EPSS);
13301333

13311334
/* power-up all before initialization */
13321335
hda_set_power_state(codec,
@@ -3558,8 +3561,7 @@ static void hda_set_power_state(struct hda_codec *codec, hda_nid_t fg,
35583561
/* this delay seems necessary to avoid click noise at power-down */
35593562
if (power_state == AC_PWRST_D3) {
35603563
/* transition time less than 10ms for power down */
3561-
bool epss = snd_hda_codec_get_supported_ps(codec, fg, AC_PWRST_EPSS);
3562-
msleep(epss ? 10 : 100);
3564+
msleep(codec->epss ? 10 : 100);
35633565
}
35643566

35653567
/* repeat power states setting at most 10 times*/

sound/pci/hda/hda_codec.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -866,6 +866,7 @@ struct hda_codec {
866866
unsigned int ignore_misc_bit:1; /* ignore MISC_NO_PRESENCE bit */
867867
unsigned int no_jack_detect:1; /* Machine has no jack-detection */
868868
unsigned int pcm_format_first:1; /* PCM format must be set first */
869+
unsigned int epss:1; /* supporting EPSS? */
869870
#ifdef CONFIG_SND_HDA_POWER_SAVE
870871
unsigned int power_on :1; /* current (global) power-state */
871872
int power_transition; /* power-state in transition */

sound/pci/hda/patch_sigmatel.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4541,6 +4541,9 @@ static void stac92xx_line_out_detect(struct hda_codec *codec,
45414541
struct auto_pin_cfg *cfg = &spec->autocfg;
45424542
int i;
45434543

4544+
if (cfg->speaker_outs == 0)
4545+
return;
4546+
45444547
for (i = 0; i < cfg->line_outs; i++) {
45454548
if (presence)
45464549
break;
@@ -5529,6 +5532,7 @@ static int patch_stac92hd83xxx(struct hda_codec *codec)
55295532
snd_hda_codec_set_pincfg(codec, 0xf, 0x2181205e);
55305533
}
55315534

5535+
codec->epss = 0; /* longer delay needed for D3 */
55325536
codec->no_trigger_sense = 1;
55335537
codec->spec = spec;
55345538

0 commit comments

Comments
 (0)