Skip to content

Commit a1a50c8

Browse files
ffainellidavem330
authored andcommitted
fsl/man: Inherit parent device and of_node
Junote Cai reported that he was not able to get a DSA setup involving the Freescale DPAA/FMAN driver to work and narrowed it down to of_find_net_device_by_node(). This function requires the network device's device reference to be correctly set which is the case here, though we have lost any device_node association there. The problem is that dpaa_eth_add_device() allocates a "dpaa-ethernet" platform device, and later on dpaa_eth_probe() is called but SET_NETDEV_DEV() won't be propagating &pdev->dev.of_node properly. Fix this by inherenting both the parent device and the of_node when dpaa_eth_add_device() creates the platform device. Fixes: 3933961 ("fsl/fman: Add FMan MAC driver") Signed-off-by: Florian Fainelli <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 33ba43e commit a1a50c8

File tree

1 file changed

+2
-0
lines changed
  • drivers/net/ethernet/freescale/fman

1 file changed

+2
-0
lines changed

drivers/net/ethernet/freescale/fman/mac.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -623,6 +623,8 @@ static struct platform_device *dpaa_eth_add_device(int fman_id,
623623
goto no_mem;
624624
}
625625

626+
pdev->dev.of_node = node;
627+
pdev->dev.parent = priv->dev;
626628
set_dma_ops(&pdev->dev, get_dma_ops(priv->dev));
627629

628630
ret = platform_device_add_data(pdev, &data, sizeof(data));

0 commit comments

Comments
 (0)