Skip to content

Commit a1dcbd1

Browse files
anholtMarc Zyngier
authored andcommitted
irqchip/bcm2836: Use a more generic memory barrier call
dsb() requires an argument on arm64, so we needed to add "sy". Instead, take this opportunity to switch to the same smp_wmb() call that gic uses for its IPIs. This is a less strong barrier than we were doing before (dmb(ishst) compared to dsb(sy)), but it seems to be the correct one. Signed-off-by: Eric Anholt <[email protected]> Acked-by: Stephen Warren <[email protected]> Signed-off-by: Marc Zyngier <[email protected]>
1 parent cb290d8 commit a1dcbd1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/irqchip/irq-bcm2836.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ static void bcm2836_arm_irqchip_send_ipi(const struct cpumask *mask,
195195
* Ensure that stores to normal memory are visible to the
196196
* other CPUs before issuing the IPI.
197197
*/
198-
dsb();
198+
smp_wmb();
199199

200200
for_each_cpu(cpu, mask) {
201201
writel(1 << ipi, mailbox0_base + 16 * cpu);

0 commit comments

Comments
 (0)